Hi,
I updated all to work with 8.2.0 of core and 8.x-3.x of migrate_plus & migrate_tools. Everything is working fine with drush but the migrate dashboard wood's when selecting a migrate group. Here is the stack trace I am receiving. It seem like perhaps this dashboard is still using the old MigrationPluginManager? I am not sure.
The website encountered an unexpected error. Please try again later.
Recoverable fatal error: Argument 4 passed to Drupal\migrate_tools\Controller\MigrationListBuilder::__construct() must be an instance of Drupal\migrate_plus\Plugin\MigrationConfigEntityPluginManager, instance of Drupal\migrate\Plugin\MigrationPluginManager given, called in /Users/palmerd/Sites/ch-blt/docroot/modules/contrib/migrate_tools/src/Controller/MigrationListBuilder.php on line 67 and defined in Drupal\migrate_tools\Controller\MigrationListBuilder->__construct() (line 52 of modules/contrib/migrate_tools/src/Controller/MigrationListBuilder.php).
Drupal\migrate_tools\Controller\MigrationListBuilder->__construct(Object, Object, Object, Object) (Line: 67)
Drupal\migrate_tools\Controller\MigrationListBuilder::createInstance(Object, Object) (Line: 249)
Drupal\Core\Entity\EntityTypeManager->createHandlerInstance('Drupal\migrate_tools\Controller\MigrationListBuilder', Object) (Line: 238)
Drupal\Core\Entity\EntityTypeManager->getHandler('migration', 'list_builder') (Line: 176)
Drupal\Core\Entity\EntityTypeManager->getListBuilder('migration') (Line: 73)
Drupal\Core\Entity\EntityManager->getListBuilder('migration') (Line: 22)
Drupal\Core\Entity\Controller\EntityListController->listing('migration')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 64)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 652)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Thanks,
Donovan
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | interdiff.txt | 8.42 KB | mikeryan |
| #4 | migrate_tools_dashboard-2825846-4.patch | 11.05 KB | mikeryan |
| #3 | 2825846-3.patch | 5.64 KB | joelpittet |
| #2 | 2825846-2.patch | 1.9 KB | joelpittet |
Comments
Comment #2
joelpittetBecause it wasn't using an interface and expecting a class that is deprecated this looks like this is the problem (see patch).
Comment #3
joelpittetFew more instances covered.
Comment #4
mikeryanFound some more stuff along those lines to cleanup - @heddn, perhaps you could review?
Comment #5
mikeryanComment #6
tobby commented@mikeryan, I came over here from https://www.drupal.org/node/2878055 and the patch in #4 did indeed work for me (for 4.x-beta1). Thanks for that heads up.
Comment #7
mikeryanOK, I'll consider that an RTBC...
Comment #9
mikeryanComment #10
kubrt commentedHit the same issue today, #4 fixes it indeed. Many thanks !
Comment #12
AndreaMaggi commentedHit the same issue today and is not resolved with #4 when runnig the drush command:
drush ms. The problem is fixed changing the file "migrate_tools.drush.inc" at line 448 from "$manager = \Drupal::service('plugin.manager.config_entity_migration');" to "$manager = \Drupal::service('plugin.manager.migration');"Comment #13
mikejon-es commented#12 worked for me
Comment #14
brayfe commentedThe patch in #4 worked for me as well! Using Drupal core 8.3.4, Migrate Plus 8.x-4.0-beta1, and Migrate Tools 8.x-4.0-beta1.
Comment #15
pasqualleThe fix is already committed on May 13, 2017, but not included in 8.x-4.0-beta1 as it was created on May 10.
use migrate_tools 8.x-4.x-dev, or apply the patch in #4
a new beta release would be nice
Comment #16
oxrc commentedSubscribe for a new beta release as the patch is crucial for 8.4.x sites.
Comment #17
JvE commentedI really wish that there were separate issue states for "Fixed in development branch" and "Fixed in released version".
Comment #18
mpp commentedAgreed with #16, it's also needed for Drupal 8.5.x.
Comment #19
debasish147 commentedcan we get patch for 8.5.x and migrate-tools:8.x-4.0-beta3, as same issue is happening here.
Comment #20
lithiumlab commentedHit the same issue today after upgrading 8.4.x site to 8.5.x site.
Along with migrate_tools beta2 to 4.x-dev.
I've installed migrate_tools without composer for some reason a while back using the backend UI, it was installed in modules/ instead of modules/contrib.
i've uninstalled the the migrate_tools module cleared the cache and removed the folder from modules/ directory mannually.
then proceeded to install via composer with:
drush updatedb
drush entup
drush cr
just in case.
getting this error:
Notice how something still is requesting an file in the old route.
What are your suggestions?
drush pmu migrate_tools -y does removes the error but i can't of course use my custom migrations.
i wonder why is the module still being referenced in the old route.