This is a small helper module and I believe it will grow with time. Main idea is to add some flexibility to render for process, each time we have to add some hook suggestion or preprocess functions etc.
So now you will have some of these things just out of the box like:
suggestions: $theme_name . '_' . $form_id
preprocess functions: $theme_name . '_preprocess_form__' . $form_id

Project URL: https://www.drupal.org/node/2776863
Git clone command: git clone --branch 8.x-1.x https://git.drupal.org/sandbox/shumer/2776863.git

Comments

shumer created an issue. See original summary.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

hesnvabr’s picture

hesnvabr commented

I cloned this project but i don't found this module in my local site.

arun ak’s picture

arun ak commented
Status: Needs review » Needs work

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity. Module just adding custom template suggestion to all drupal forms. It is not always required templates for all forms including admin pages. You can provide separate configuration page or hooks to avoid this or add relevant conditions in whippy_forms_form_alter().
Secure code
Yes: Meets the security requirements.

Thanks,
ARUN AK

shumer’s picture

shumer commented
Status: Needs work » Needs review

Readme file added, also configuration added to make functionality more user friendly and allow to interract only with required themes.

shumer’s picture

shumer commented

It is not always required templates for all forms including admin pages.

As for this one, you just don;t eed to create template or preprocess function if you don't want to modify your form, in this case default Drupal workflow will be used, so I don't see any problem here.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxshumer2776863git

I'm a robot and this is an automated message from Project Applications Scraper.

shumer’s picture

shumer commented
Status: Needs work » Needs review

Errors fixed

miritas’s picture

miritas commented

Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows.
Code long/complex enough for review
Yes: Follows.
Secure code
Yes: Meets the security requirements.

m.krestnicov’s picture

m.krestnicov commented

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.

m.krestnicov’s picture

m.krestnicov commented
Status: Needs review » Reviewed & tested by the community
arun ak’s picture

arun ak commented
Status: Reviewed & tested by the community » Needs work
  1. Configuration link(/admin/config/whippy_forms) is not displaying in any of the config pages or menu. Use whippy_forms.links.menu.yml to add configuration link in admin menu. Also you can add config url in whippy_forms.info.yml to make it display Configure link in module listing page.
  2. I am using theme Bartik, and I added bartik--user-register-form.html.twig file in the following path /core/theme/bartik/templates/bartik--user-register-form.html.twig and it is not working. But if I rename the file as whippy-forms--user-register-form.html.twig then it is working fine.

Thanks,
ARUN AK

shumer’s picture

shumer commented
Status: Needs work » Needs review

Links were added, so now you can find a link on Configuration page. Also theme hook suggestions were updates, so your issue with templates should be fixed.

m.krestnicov’s picture

m.krestnicov commented
Status: Needs review » Reviewed & tested by the community

Link is present. Templates for bartik and other themes worked for me.

misc’s picture

misc commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, shumer!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.