Call parent constructor of ctools_context_optional class and define visibility for items of context classes [#2765135]

Problem/Motivation

Constructor of ctools_context_required class called incorrectly from ctools_context_optional class.
Since we are progressive people and looking forward then let's get rid from obsolete var keyword.

Proposed resolution

Use call_user_func_array() in ctools_context_optional::__construct().
Replace/add public instead of var statements.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#2	ctools-context_optional_fix_construct-2765135-2.patch	5.11 KB	BR0kEN

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

13 July 2016 at 00:35

BR0kEN created an issue. See original summary.

Comment #2

BR0kEN

Ukrainian

CreditAttribution: BR0kEN as a volunteer and at FFW for FFW commented 13 July 2016 at 00:37

Status:

Active

» Needs review

File	Size
ctools-context_optional_fix_construct-2765135-2.patch	5.11 KB

Comment #3

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 22 January 2019 at 02:40

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

The 3 year old patch to context.inc does not apply to the latest ctools 7.x-1.x-dev.

Checking patch includes/context.inc...
error: while searching for:
 * of the context is important.
 */
class ctools_context {
  var $type = NULL;
  var $data = NULL;
  // The title of this object.
  var $title = '';
  // The title of the page if this object exists
  var $page_title = '';
  // The identifier (in the UI) of this object
  var $identifier = '';
  var $argument = NULL;
  var $keyword = '';
  var $original_argument = NULL;
  var $restrictions = array();
  var $empty = FALSE;

  function __construct($type = 'none', $data = NULL) {
    $this->type  = $type;
    $this->data  = $data;
    $this->title = t('Unknown context');
  }

  function is_type($type) {
    if ($type == 'any' || $this->type == 'any') {
      return TRUE;
    }

error: patch failed: includes/context.inc:28
error: includes/context.inc: patch does not apply