Commerce Repeat Order allows end user to repeat there order again and again.

This module allows to repeat customer order just by creating an simple link or button.

i.e. Link can be created as l('Repeat Order','commerce-repeat-order/%') where % is order id which needs to be passed dynamically to repeat that order.

Order of same user will be allowed to repeat. Order of another user will not be added to cart by different customer.

Git clone URL:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/pratik.mehta19/2763365.git commerce_repeat_order

Project Page : https://www.drupal.org/project/commerce_repeat_order

My Reviewed projects:

https://www.drupal.org/node/2893787#comment-12163031
https://www.drupal.org/node/2888697#comment-12162988
https://www.drupal.org/node/2893090#comment-12162967

Comments

pratik.mehta19 created an issue. See original summary.

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer commented
Assigned: pratik.mehta19 » Unassigned
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxpratikmehta192763365git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer commented

Git clone URL:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/pratik.mehta19/2763365.git commerce_repeat_order

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer commented
pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer commented
Status: Needs work » Needs review
pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer commented
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented

Hi pratik.mehta19,

Automated Review

Please check the errors in automatic reviews
http://pareview.sh/pareview/httpsgitdrupalorgsandboxpratikmehta192763365...
As per above review please set the git default branch & please fix some coding issues.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
No: Causes module duplication and/or fragmentation.
Similar project is - Commerce Reorder
For this you need to specify how your module is different from the other commerce reorder module ?
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Nothing
  2. (+) 1. It would be good, if you implement hook_help in your module.
    2. it's better to use t() in commerce_repeat_order_settings_form() in commerce_repeat_order.module file.
  3. Just a recommendation - Nothing.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

ganesh_kumar’s picture

ganesh_kumar CreditAttribution: ganesh_kumar commented

Hi pratik.mehta19,

Few other tweaks like master branch need to be fixed and rest follow the above mentioned issued posted by Mr.Yogesh Pawar .

Automated Review

Fix all the Pareview issue listed in the given url http://pareview.sh/pareview/httpsgitdrupalorgsandboxpratikmehta192763365...

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts
No duplication
No: Causes module Please refer the repeated module if you want to add any feature kindly contact the admin to give maintainer access to add feature in this module https://www.drupal.org/project/commerce_reorder duplication and/or fragmentation
Master Branch
No: Does not follow the guidelines for master branch
Licensing
Yes: Follows the licensing requirements
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template
Code long/complex enough for review
No: Does not follow this module is approval for one time approval guidelines for project length
Secure code
[Yes: Meets the security requirements. / No: List of security issues identified.]
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Major finding, needs work
  2. (+) Release blocker
  3. Just a recommendation

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

ganesh_kumar’s picture

ganesh_kumar CreditAttribution: ganesh_kumar as a volunteer and commented

Hi pratik.mehta19,

Few tweaks are here default branch does not followed guidelines for master branch and rest follow the above comments.

Automated Review

Fix all the Pareview issue listed in the given url http://pareview.sh/pareview/httpsgitdrupalorgsandboxpratikmehta192763365...

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts
No duplication
No: Causes module Please refer the repeated module if you want to add any feature kindly contact the admin to give maintainer access to add feature in this module https://www.drupal.org/project/commerce_reorder duplication and/or fragmentation
Master Branch
No: Does not follow the guidelines for master branch
Licensing
Yes: Follows the licensing requirements
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template
Code long/complex enough for review
No: Does not follow this module is approval for one time approval guidelines for project length
Secure code
[Yes: Meets the security requirements. / No: List of security issues identified.]
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Major finding, needs work
  2. (+) Release blocker
  3. Just a recommendation

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented

Hi pratik.mehta19,

Module duplication is not a application blocker, but you can talk with maintainer of Commerce Reorder & see if you can collaborate with each other & also he can mention your project as similar project on his project page.

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer commented

Hi Yogesh,

I would like to brief what is exact difference in Commerce Reorder and my module.

  • Commerce Repeat Order Provides a link which can be placed at any of tpl file or module. Just passing order id in parameter would repeat customer order
  • Validation of order of same customer would be repeated
  • Admin can select an option whether to replace existing order from cart or could add additional products to cart

So this would be more generic module and more useful from customer point of view.

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 commented
Priority: Normal » Major
Issue tags: -ecommerce +PAreview: review bonus

Find my reviewed module links as below:

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 commented
Issue summary: View changes
ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
CreditAttribution: ashishdalvi at Iksula, Blisstering Solutions commented
Status: Needs review » Needs work

Automated Review

Minor git issue:

There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732

Manual Review

Individual user account
Yes.
No duplication
Yes. It is different in implemetation and usages compare the existing module commerce reorder.
Master Branch
No. :There is still a master branch, make sure to set the correct default branch.
Licensing
Yes.
3rd party assets/code
No.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes
Secure code
Yes
Coding style & Drupal API usage
  1. Just a recommendation
  2. "commerce repeat order admin access" permission seams to be unwnated, we can use the existing permission from commerce module "view own commerce_order entities"
pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 commented
Status: Needs work » Needs review

Hi Ashish,

Have deleted default branch and code changes are done.

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer and commented
Priority: Major » Critical

Due to no activity for more than 2 weeks. Updating the issue status to critical

arshadkhan35’s picture

arshadkhan35 CreditAttribution: arshadkhan35 commented
Status: Needs review » Reviewed & tested by the community

looks good, Changing it to RTBC.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pratik.mehta19’s picture

pratik.mehta19 CreditAttribution: pratik.mehta19 as a volunteer and commented

@kiamlaluno, Thank you for your response. Looking forward to more module contribution and helping community :)

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Priority: Critical » Normal