Can't scroll vertical toolbar tray to reveal last item, applies to both mobile and desktop breakpoints

I was able to replicate the issue and tested #11, its finally working smoothly. Kudos to Sven

I reproduced the error on 8.1.7 following the steps in #2 and this patch fixes the problem. Great job Sven.

Before:

After:

Attempting to tag for JS subsystem maintainer review, I'm not familiar enough with displace to know if calling it like this is good or not.

Thanks for the work on this @svenryen!

this is overcomplicated at my first sight.

We could either drop `padding-bottom` to .toolbar-tray-vertical. Or `max-height: calc(100% - height)`

(IMO, with the `max-height` workaround we can leave the style there all time, we only hit the limitation at edge case.)

Drupal.displace is redundant in this case. On each toolbar toggle, we called `Drupal.toolbar.ToolbarVisualView.render` function that has a Drupal.displace calls at the final point.

To committers,
I'd like to have a final review if time is allowed :) I want to make sure there're no conflicts with #2542050: Toolbar implementation creates super annoying re-rendering. for our future work.

Thanks All!

@droplet thanks for the lightning quick review! Yes you can definitely have final review, this is a bugfix so it can go in past beta freeze I think.

It's been reviewed.

There's instructions in #19 on the next step here

I'm adding the 'Needs reroll' tag, but it actually needs a whole new approach per #19

just rerolled patch #11

Looks like patch #34 is having some issues moving back to NW

re-rolling patch #11 for 9.4.x

Is working fine for me for version -9.4.x-dev

CI is failing for all patches here. The patch should also get a code review before moving to RTBC.

Adding patch by fixing custom command failure form #38.

Verified and tested patch #43 on Drupal 9.4.x. 
Patch applied successfully.

Test Steps:
1. Fresh install Drupal 9.4.x.
2. Apply the given patch.
3. Make the window narrow enough to display the toolbar tray as a sidebar.
4. Expand some menu items in the toolbar tray so that the scrollbar is shown.
5. Attempt to scroll to the bottom to see the last menu item in the toolbar tray.

Test Result: 
I'm not able to scroll vertical toolbar tray to reveal the last item after reproducing the error. Adding screenshot for reference.

Thanks @narendra.rajwar27 for the patch.

Checked issue on chrome, I have reproduced the error on my local with Drupal 9.4.x. And applied the patch to the Drupal Local setup by i'm even not able to made to scroll down to "Help" in the vertical tab. Hence move back this issue to needs work. Adding the screenshot after applying the patch. Thanks

@sahil I tested it on Drupal 9.4 and it seems to work without any issues. It could possibly be an issue with your cache

- The issue summary is clear
- Steps to reproduce are provided in the comments
- The patch applies cleanly and fixes the issue
- Tested on multiple browsers

Marking this as RTBC unless any thing else is pending

CI is still failing

Updating the patch as per the comment #46 i have tested on on a different setup it working as expected as seen that the latest patch is producing CI issue, so as addressing that updating the patch along with the interadiff file.

Fixed CCF for #48.
Please review.

2762963-49.patch in #49 did not work for me. I didn't use the interdiff txtfile.

The only way I can see the "help" link at the very bottom is by increasing the height of the window. I cannot use the vertical scrollbar to reach it.

Patch #49 not working as expected on drupal 9.4.x-dev.
After applying patch not able to scroll down to "Help" menu in vertical tab so moving issue to needs work.

Patch #49 didn't apply for 9.5.x, providing a fix for the same. Couldn't generate a interdiff

Applied the patch #49 on drupal 9.4.x and it didn't work as expected.

@safoora_mir why do we need to change the version to 9.4? Ideally, you should be testing the latest available patch in the issue. Also if its a failure could you please provide details of the failure so that it is easier for anyone else to pick up.

With #53 came across an issue with the toolbar margin, fixed it in the patch below

@ameymudras i think there was some confusion from my end. I apologise for changing the status of the issue. Talking about the failure of patch #49 on Drupal 9.4x, i faced the same issue with the toolbar margin and the original issue persisted even after applying the patch.

Able to reproduce the issue.
Tried to apply patch #56 on Drupal 9.5.x-dev but the patch failed to apply

See the below error

Checking patch core/modules/taxonomy/src/TermForm.php...
Hunk #1 succeeded at 206 (offset -5 lines).
Checking patch core/modules/toolbar/js/views/ToolbarVisualView.es6.js...
Checking patch core/modules/toolbar/js/views/ToolbarVisualView.js...
error: while searching for:
    },
    adjustPlacement: function adjustPlacement() {
      var $trays = this.$el.find('.toolbar-tray');
      if (!this.model.get('isOriented')) {
        $trays.removeClass('toolbar-tray-horizontal').addClass('toolbar-tray-vertical');
      }
    },
    loadSubtrees: function loadSubtrees() {

error: patch failed: core/modules/toolbar/js/views/ToolbarVisualView.js:135
error: core/modules/toolbar/js/views/ToolbarVisualView.js: patch does not apply

Applied patch #56 applied successfully in drupal-9.5.x-dev
Thanks for the patch
For ref sharing screenshots...

patch #56 worked successfully.

Re #56

index 87c8fc5b3f..81aced9879 100644
--- a/core/modules/toolbar/js/views/ToolbarVisualView.es6.js
+++ b/core/modules/toolbar/js/views/ToolbarVisualView.es6.js
@@ -316,10 +316,25 @@
        */
       adjustPlacement() {

Drupal no longer uses.es6.js files. If this qualifies for a 9.x backport that could happen there. For now, this should target the current dev branch, 10.1.x.

diff --git a/core/modules/taxonomy/src/TermForm.php b/core/modules/taxonomy/src/TermForm.php
index af287ba881..d8603582e7 100644
--- a/core/modules/taxonomy/src/TermForm.php
+++ b/core/modules/taxonomy/src/TermForm.php
@@ -211,8 +211,13 @@ public function save(array

Why is TermForm being changed?

And we're good on Screenshots. Please no more screenshots.

Addressed 1 from #62 as i updated the js files for 10.1.x.
Could not address the second point.

@_utsavsharma Applied patch #63 for 10.1.x

before-patch-63.gif
after-patch-63.gif

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [Meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.