og:image does not parse url from image field properly when there is a comma in the alt field

I also had that problem!
I tested and concluded that the metatag is not being!
This is 99%

I'm getting this error with the module https://www.drupal.org/project/field_tokens

I am preparing a patch to fix it!

I'm sorry. Dear @seancasey, change the issue as you see fit

I'm reopening this to fix image handling so it only looks at the SRC attribute of the IMG tag.

Working on porting D7's image tests to D8. This is a copy/paste/rename-some-things first step, more to come.

Just faced this issue as well. Weird enough that the image_src metatag doesn't have this issue with the exact same tokens. Is this because og:image is set to be multi value?

Lets do the tests in #2628472: Write tests for image handling first and then work on fixing this.

@Lukas von Blarer: It indeed only happens to image metatags which may contain multiple values. MetaNameBase::parseImageURL() explodes $value by commas which may occur between tags as separator, but may also occur inside attributes or even outside image tags depending on whatever the field formatter returns.

I attached a patch which explodes by commas of they are actually between tags, but also I added a URL validator just to be sure. I guess there still are situations that are uncovered since the implementation heavily leans on comma separated tags which totally depends on the result of field formatters, but I hope the patch is a small improvement.

8.x-1.0 is out, so this is fair game again.

Need to finish #2628472: Write tests for image handling first.

hi! I'm experiencing the same issue -- any alt tag with a comma in it is causing the [node:field_image] token to not render the og:image tag correctly -- instead it outputs mangled html, like so:

<meta property="og:image" content="http://niams.iqscloud.net/sites/default/files/field/image/achilles_image-new.jpg, likely placing increased  strain on the Achilles tendon and rendering it more vulnerable to injury.&quot; typeof=&quot;foaf:Image&quot; itemprop=&quot;image&quot; /&gt;







" />

I'm not experienced at testing/fixing modules. We have a site about to go into Production, and this is proving to be a major issue for is. Any ideas on how i could remedy this (removing alt tags is not an option, and deleting all commas in thousands of alt tags also not an option.)

Thanks for any help you can provide.

Hello;

I can report the same problem and field_tokens is not the issue because i'm not using it.

I'm using metatag 8.x-dev.

@lmeurs, this will not work correctly if you have something like this:
"[node:field_image],http://my_site.example/themes/custom/my_theme/fallback_image.png" <- the path to a fallback image...

@roshkovanv: Thanks for your work on this. As soon as #2628472: Write tests for image handling is finished I'll be able to review the implications of this, and improve the tests.

FYI, For those looking for a quick fix, you can avoid this issue entirely since #2611866: Add image style tokens for image fields was committed to the Token module. You can get the raw URL for an image style via tokens, instead of just getting the HTML markup of the image. In fact, maybe Meta Tag should indicate that in the description for such image fields, because it's not obvious you can use tokens like this (they don't appear in the token browser).

See the patch in the reference issue for the format for the token. This allows you to control the image style as well :)

Rerolled the patch from #21 (#2911435: Streamline the HTML output logic made it inapplicable). Now my og:image tag renders properly even if I use the original image from an image field which has an alt attribute containing comma(s) and I don't override anything in the token display mode.

Any plans to release the fix for this? If more development is needed, I'm willing to help.

Patch #24 not work for me.

Rerolled patch #24 for the latest metatag release (8-x-1.4).

Let's see what the testbot says.

ahh OK rerolled for 8.x-1.x-dev branch ..

Rerolled patch from #32 for 8.x-1.16.

Missed the use statement for UrlHelper. Updated patch.

Let's run that one by the testbot.

I had created a patch for this bug before finding the issue, I'm posting it anyway, just in case it is deemed useful. Not to say this should be the new "official" patch to review now, just curious to see if the testbot likes it.

This should work better.

I committed #42. Thank you.

This error has occurred again. Please investigate.
Drupal Version: 9.5.2
Metatag: 8.x-1.x-dev

Please open a new issue and provide details of the errors that show on your site, your site's logs, etc that might help track down the problem.