After #2613654: Parse image fields for image URLs was added, we need to add tests to make it clear how image fields should work.

CommentFileSizeAuthor
#6 metatag-n2628472-6.patch19.76 KBdamienmckenna
#4 metatag-n2628472-4.patch19.87 KBdamienmckenna
#2 metatag-n2628472-2.patch20.42 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2628472-2.patch20.42 KB

Moving the tests over from #2761909: og:image does not parse url from image field properly when there is a comma in the alt field. I'm expecting this to not work.

Status: Needs review » Needs work

The last submitted patch, 2: metatag-n2628472-2.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2628472-4.patch19.87 KB

Updated to be a BrowserTest.

Status: Needs review » Needs work

The last submitted patch, 4: metatag-n2628472-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2628472-6.patch19.76 KB

WIP.

Status: Needs review » Needs work

The last submitted patch, 6: metatag-n2628472-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Also expand the test for multiple items to confirm what happens when there's a blank item.