[D8] Maintenance Notifications

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi sandeepreddyg,

Module looks good. Some suggestions are :

1: Follow the Readme template for the readme.txt https://www.drupal.org/node/2181737
2: Please add configuration and permission links in info file.
3: Add hook_help().
4: To find configure link is difficult So You can add a local.task for maintenance "base_route:admin/config/development/maintenance"

Hi sandeepreddyg,

I tried to test your module , Its working fine only one functionality is not working which is

1: Not accepting multiple emails on configuration form, Please see the attachement

In maintenance_notifications.info.yml you don't need:

config: maintenance_notifications.form
# version: VERSION

In maintenance_notifications.permissions.yml

You can drop description: 'Configration Maintenance Notification' completely as it doesn't bring any different help message than the permission title.

Also, I think your permission machine name is wrong either in this file or in maintenance_notifications.routing.yml which has _permission: 'administer maintenance_notifications'

In maintenance_notifications.module

In hook_help()

You have a typo line 19: maintennance -> maintenance
You can drop default: altogether (line 22)

Your parameters for hook_form_FORM_ID_alter() are wrong (D7, not D8). See https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21fo...

In hook_mail(), you should not invoke Drupal\Component\Utility\SafeMarkup directly. Instead, having a use statement at the top of the file would be recommended. Also SafeMarkup is deprecated so you should consider replacing it.

In MaintenanceNotification.php

Perhaps you could replace valid_email_address($maintenance_user) by \Drupal::service('email.validator')->isValid($maintenance_user)

Also, in submitForm(), you could simplify your code. E.g.

$config = $this->config('maintenance_notifications.settings');
$config->set('send_mail', $form_state->getValue('send_mail'))->save();
$config->set('users_list', $form_state->getValue('users_list'))->save();
etc.

Could become:

$this->config('maintenance_notifications.settings');
  ->set('send_mail', $form_state->getValue('send_mail'))->save();
  ->set('users_list', $form_state->getValue('users_list'))->save();
  etc.
  ->save();

Hi sandeepreddyg,

In updated code when i am putting my site in maintenance i am not getting any mail or messages. (I checked on Screen and logger both places.

And i am getting following error : "The website encountered an unexpected error. Please try again later."

Error log message is :

Error : Recoverable fatal error: Object of class Drupal\\Core\\Language\\Language could not be converted to string in /var/www/html/drupal-8/core/lib/Drupal/Core/StringTranslation/Translator/CustomStrings.php on line 37, referer: http://localhost/drupal-8/admin/config/development/maintenance

Please correct me , if i am doing something wrong.

Thanks

I think we don't have any blockers now. So i am marking as RTBC.

Thanks for the quick fixes, @sandeepreddyg.

One nitpick I have is you could use Drupal\Core\Form\FormStateInterface; to invoke FormStateInterface $form_state instead of \Drupal\Core\Form\FormStateInterface $form_state in hook_form_FORM_ID_alter() - Also, it's missing a whitespace between the 1st and 2nd parameters.

I will update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.