Add only theme wrapper and attributes if rows not empty [#2739001]

Comment	File	Size	Author
#10	2739001-10.patch	923 bytes	marvin_B8
#10	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 3 pass PHP 5.5 & PostgreSQL 9.1, D8.2 3 pass PHP 5.5 & SQLite 3.8, D8.2 3 pass PHP 5.6 & MySQL 5.5, D8.2 3 pass PHP 7 & MySQL 5.5, D8.2 3 pass PHP 7 & PostgreSQL 9.1, D8.2 3 pass PHP 7 & SQLite 3.14, D8.2 3 pass
#2	add_empty_message.patch	757 bytes	Sam152
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.2 Patch failed to apply PHP 5.5 & SQLite 3.8, D8.2 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.2 Patch failed to apply PHP 7 & MySQL 5.5, D8.2 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.2 Patch failed to apply PHP 7 & SQLite 3.14, D8.2 Patch failed to apply
	add_empty_message.patch	757 bytes	marvin_B8

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 June 2016 at 20:09

marvin_B8 created an issue. See original summary.

Comment #2

Sam152 CreditAttribution: Sam152 commented 2 June 2016 at 10:42

File	Size
add_empty_message.patch	757 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.2 Patch failed to apply PHP 5.5 & SQLite 3.8, D8.2 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.2 Patch failed to apply PHP 7 & MySQL 5.5, D8.2 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.2 Patch failed to apply PHP 7 & SQLite 3.14, D8.2 Patch failed to apply

Why didn't testbot run?

Comment #3

2 June 2016 at 10:46

Status:

Needs review

» Needs work

The last submitted patch, 2: add_empty_message.patch, failed testing.

Comment #4

2 June 2016 at 10:46

The last submitted patch, 2: add_empty_message.patch, failed testing.

Comment #5

2 June 2016 at 10:47

The last submitted patch, 2: add_empty_message.patch, failed testing.

Comment #6

2 June 2016 at 10:47

The last submitted patch, 2: add_empty_message.patch, failed testing.

Comment #7

2 June 2016 at 10:47

The last submitted patch, 2: add_empty_message.patch, failed testing.

Comment #8

2 June 2016 at 10:47

The last submitted patch, 2: add_empty_message.patch, failed testing.

Comment #9

2 June 2016 at 10:48

The last submitted patch, 2: add_empty_message.patch, failed testing.

Comment #10

marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commented 2 June 2016 at 17:32

Status:

Needs work

» Needs review

File	Size
2739001-10.patch	923 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 3 pass PHP 5.5 & PostgreSQL 9.1, D8.2 3 pass PHP 5.5 & SQLite 3.8, D8.2 3 pass PHP 5.6 & MySQL 5.5, D8.2 3 pass PHP 7 & MySQL 5.5, D8.2 3 pass PHP 7 & PostgreSQL 9.1, D8.2 3 pass PHP 7 & SQLite 3.14, D8.2 3 pass

2 files were hidden/shown/deleted

File	Size
add_empty_message.patch	757 bytes

add_empty_message.patch	757 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.2 Patch failed to apply PHP 5.5 & SQLite 3.8, D8.2 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.2 Patch failed to apply PHP 7 & MySQL 5.5, D8.2 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.2 Patch failed to apply PHP 7 & SQLite 3.14, D8.2 Patch failed to apply

Comment #11

Sam152 CreditAttribution: Sam152 commented 3 June 2016 at 01:19

+++ b/views_infinite_scroll.module
@@ -34,13 +34,15 @@ function views_infinite_scroll_preprocess_views_view(&$vars) {
   if ($view->getDisplay()->isPagerEnabled() && !empty($vars['rows'])) {
...
+      if (!empty($vars['rows'])) {

I went to commit this but realised the same check already happens further up the function.