Project : Link Data Attribute

The Link Data Attribute module provides a simple way to include HTML 5 data-* attributes to any Link field on site building.

With this module, links can be easily added with a data-* attribute that can be used on your JavaScript and/or your CSS files.
A quick reference to HTML-5 data-* attributes usage.

Besides that, it also allows you to have a data being provided on site building that can be used programmatically on many hooks and while building a template.

GIT CLONE :

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/felipe/2709259.git
link_data_attributes
cd link_data_attributes

CommentFileSizeAuthor
#5 Selection_534.png11.51 KBbuenos
#5 Selection_533.png15.55 KBbuenos
#5 Selection_532.png15.56 KBbuenos

Comments

fcampos created an issue. See original summary.

fcampos’s picture

fcampos commented

Could someone kindly review this new module, please ?

If you have any questions please e-mail me at felipeoc@ciandt.com for a faster awnser.

Thanks!

fcampos’s picture

fcampos commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

buenos’s picture

buenos commented
Status: Needs review » Needs work
StatusFileSize
new Selection_532.png15.56 KB
new Selection_533.png15.55 KB
new Selection_534.png11.51 KB

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation. Although I've found a conversation about the need of such feature for menu links - HTML5 Custom Data Attributes
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) CodeSniffer found one error in 2 files: End of line character is invalid; expected "\n" but found "\r\n"
  2. (*) If I check option "Display "custom data" as HTML 5 Data Attribute." and then uncheck option "Enable custom HTML 5 data-* Attribute." - Data Attribute Name field is still available in the field settings while it's impossible to manage this field on the node form - see screenshots Selection_532.png and Selection_534.png
  3. If I uncheck option "Display "custom data" as HTML 5 Data Attribute." - html structure looks like this - see screenshot Selection_533.png - is this "dataattribute" meant to be there?
  4. Is it possible to add more than one data attribute to same link field? I think it would make much more use for this module

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

fcampos’s picture

fcampos commented
Assigned: Unassigned » fcampos
fcampos’s picture

fcampos commented

Hello buenos.

Thanks for your help!

1 - Are you using Windows to do run CodeSniffer?
This code was created on Linux and has '\n' and no '\r\n'. I even changed it locally to be '\r\n' so my CodeSniffer would complain, which actually did. But I did not commit that change. Can you confirm that please?

2 - Fixed!

3 - Fixed!

4 - Some coworkers suggested that, and even suggested to have this feature on any type of field. Both are great ideas and will be implemented later.
But I believe a new module would be More suitable. And I already am doing it, as I can. This is my new module's sandbox:

https://www.drupal.org/sandbox/felipe/2757345

When it's done I'll refer it from my other module, so if someone is looking for that functionality on other field type, they will find it easily.

Even the functionality being similar on Link fields, I shall keep this module because the new module will require new Database structure, and this one takes advantage of Link's one. Avoiding Database changes.

Thanks for all your help! Please keep suggesting ideas!!!

fcampos’s picture

fcampos commented
Assigned: fcampos » Unassigned
Status: Needs work » Needs review
pookmish’s picture

pookmish commented

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation. Although I've found a conversation about the need of such feature for menu links - HTML5 Custom Data Attributes
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage

  • Not very intuitive when adding data attributes
  • Not possible to add additional attributes.
  • Maybe improve form descriptions on field edit form.

Otherwise, I think this could be really useful with the increasing use of data attributes.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

@pookmish: Looks like you forgot to change the status. Is this now RTBC after your review or are the re application blockers left and this should be set to "needs work"?

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Reviewed & tested by the community

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
No: Causes module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Please refer to this link https://www.drupal.org/node/2181737 for README Template
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
Nothing.

This module looks good and working for me. also there are no blocker points left.
So i am marking this module as RTBC.

fcampos’s picture

fcampos commented
fcampos’s picture

fcampos commented

Any updates on this issue?

Is there anything I could help with to make this project move forward ?

Thanks for your help!

misc’s picture

misc commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, fcampos!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.