Problem/Motivation

Search on drupal.org is disabled at the moment so I apologize if this is already discussed elsewhere. When using Google to search for similar issues, I found another person say "I wrongly assumed it was about 'Localization' because its path is 'locale'" so it seems I'm not the only one with the problem I'm about to describe.

I recently changed the time zone in the system settings for a site I manage and realized that it was unnecessarily difficult to inform my site members that they might need to update their own time zone settings. In my mind I started to picture countless support emails where my members were asking me where the "time zone settings" were in the account settings.

After 5 seconds, I did what I think anyone would do and changed the "Locale settings" string on the user edit page to "Time zone settings" (this particular site is in English, so this patch only affects the system.module and system.admin.inc files).

This should also be an unnecessarily step for Drupal administrators. I understand if the Locale settings fieldset was destined for more features and form widgets, but from what I can tell it only contains the time zone settings and should therefore be named "Time zone settings."

Steps to reproduce

The screenshots in #9 are still the same on Drupal 9.2.x.

Proposed resolution

Original proposal - Change the "Locale settings" string on the user edit page to "Time zone settings".

In #9 chris_h recommends
Change the "Locale settings" string on the user edit page to "Time zone settings".
On admin/config/regional/settings change Locale to Country
On admin/config/people/accounts/form-display change Timezone to Time zone

Remaining tasks

Decide is this should be done.

User interface changes

Yes. No screenshots yet.

API changes

Data model changes

Release notes snippet

Comments

stevenpatz’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

Tor Arne Thune’s picture

Version: 7.x-dev » 8.x-dev
StatusFileSize
new15.59 KB

Still a valid issue after the release of 7.0. Moving to 8.x. See attached screenshot for how it is now on the user edit page.

albert volkman’s picture

Status: Needs work » Needs review
StatusFileSize
new529 bytes

Updated for 8.x.

Status: Needs review » Needs work

The last submitted patch, 4: local_settings_string-272397-4.patch, failed testing.

albert volkman’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new529 bytes

Re-roll

jhedstrom’s picture

Issue tags: +Needs usability review

Patch still applies, tagging for usability review.

chris_h’s picture

I've reviewed and this comes up in a few places

1) The installer, which uses default country/time zone

installer

2) the user edit page, which uses Locale settings (can't set country)

user edit

3) admin/config/regional/settings which uses Locale/Time zones

config

4) admin/config/people/accounts/form-display which uses Timezone

form display

For consistency we should amend to:

1) no change
2) change to Time zone as per patch
3) change Locale to Country
4) change Timezone to Time zone

mile23’s picture

Status: Needs review » Needs work

Wondering what has changed since #9...

2) User edit form still uses 'Locale.'

3) admin/config/regional/settings still uses Locale and Time Zones.

4) admin/config/people/accounts/form-display still uses Timezone.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

Title: String change: "Locale settings" on the user edit page should be "Time zone settings" » Update "Locale settings" on the user edit page to "Time zone settings"
Issue tags: +Bug Smash Initiative

I am not so sure about this change, the fieldset label is 'Locale settings' and the field label is 'Timezone'. I don't really think it's adding much to update the fieldset to be 'Timezone settings' when the field label says this already.

Would it make more sense to remove the fieldset and just display the field within the form, as with the other user fields? (But then, do we need to do the same for 'Contact settings'? Or is there a reason it's in a fieldset?)

ramya balasubramanian’s picture

Hi @pameela,
As per your previous comment, can we remove the fieldset and keep the fieldlabel alone in User edit page & Contact settings page. Please have a look and let me know what needs to be changed here.

quietone’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new27.37 KB

I've read the issue, checked the current state of the pages on Drupal 9.2.x. and agree with #19, I am not sure about this change. And as she points out removing the fieldset for the time zone is inconsistent with the 'Contact settings'

It would be helpful to know how christefano communicated to users of the site that they might need to update their time zone settings.

Actually, after more thought on this maybe this is a won't fix. However, since this affect user facing text I am not comfortable changing the status to that. How about, Needs Review, to help reach a consensus.

Added a screen shot with the contact settings.

kristen pol’s picture

My 2 cents after reading #9 and later:

1) The installer, which uses default country/time zone

Agree that no change is needed.

2) the user edit page, which uses Locale settings (can't set country)

Options: a) leave as is, b) change to Time zone as per patch, or c) remove fieldset

I think it's best to leave as is or remove the fieldset. But, the UX team should be consulted for the latter.

3) admin/config/regional/settings which uses Locale/Time zones

I disagree with changing the fieldset label from Locale to Country because "First day of week" has nothing to do with the country, so I would leave this as is.

If this were to be made more consistent with the previous item's Locale fieldset, then the time zone settings could be combined with the country and first day of the week. So, I'd say either leave as is or ask the UX team about combining the fieldsets.

4) admin/config/people/accounts/form-display which uses Timezone

I agree that it would be good to standardize on "timezone"/"timezones" or "time zone"/"time zones" throughout the UI to be consistent. Unfortunately, the codebase uses "timezone" as one word (e.g. "Timezone for DateTimePlus") in some places and "time zone" as two words in others (e.g. "'Correct time zone field"). We could still go through the UI and make sure the usage is either one word or two words if we want but there is a good chance that the "other" usage will crop into the UI again since the codebase uses both.

At this point, I would say it would be good to consult with the UX team on their thoughts since these aren't obvious.

quietone’s picture

I discovered a related issue, which has suggests a different change to the user edit page. I rerolled it to make an up to date screenshot.

jibran’s picture

Category: Bug report » Task
Status: Needs review » Closed (duplicate)

This seems like a task now rather than a bug. Also, closing this as a duplicate of #134209: Join language and timezone settings in one single fieldset as consolidation of the fields under one fieldset and renaming it makes sense than removing the fieldset altogether.