[D7] External Link Preview

Hi Sanket,

Your module is nice.
But giving warning for the link whose html is not been fetched.

You can update with following code on line number 130 in .module file
if (isset($html) && !empty($html)) {

I was trying to add the link in link preview text field :( and forget to add into body field.
Can you please add the usage of this module in readme file so that it would be easy for others to figure out.

Hi sanket1007,

I have checked your module as manual review. Below warning message I am getting after installed your module.

Warning: DOMDocument::loadHTML(): Empty string supplied as input in extlink_preview_get_og_metatags() (line 317 of D:\xampp\htdocs\drupal-7.43\sites\all\modules\contrib\extlink_preview\extlink_preview.module).

And I am not getting link preview as you attached image. Its redirect to external link only.. So Please kindly guide me any more configuration setting is required..

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Trying to enable External Link Preview module getting syntax error in extlink_preview.module at line 114. Please refer the attached image.

Awesome module! :)

Works really great and such a relevant and highly used functionality in so many sites - FB, LinkedIn. It is a surprise that such a module didn't already exist. So thank you for working on it and brining it to the community.

I went through your code and have a few feedback -

* We can have another option while configuring the formatter settings whether to show the link in the textarea as well or not. Right now it's showing by default.
* Along with that, optionally, the preview could also be linked.
* It would be good to add comments in your code so anybody can understand how its working - which means how the module is working in code.
* At line 125, there is no need to check for $link as we are already doing it on line 124
* For an a tag with href inside single quotes, the link that is being used to fetch the page info is getting incorrectly formed. You could instead you preg_split for multiple delimiters - preg_split( "/(\"|')/", $link);
* Why was it necessary to declare a user agent for fetching the page via curl?
* You could also use php html parser functions instead of preg_match. Test out the performances of both to find out which is better.

My initial feedback. Going through the code so will come back with more feedback :)

Hi Sanket,

A great Idea for a needed module.

Manual Review:

1. For the scenario of other supported Field types, I think we should include "links", "external links" for better use.

2. For the scenario of some urls will not have an image or a default image for the OG or twitter cards. and that brings some errors or working
Warning: getimagesize
Some validation in php will take errors or warnings out.
I think that if we could have the option to select Image style will fix many issues.

3. For the scenario of adding more than one link in the page. We do not know the expected link which will be reviewed as you can see from the following screenshot.

4. Caching curl calles will save a lot, I do think drupal_http_request is much better to use. and you can have timeout, then first try, second try, third try. It's better to have fallback options.

Rewarded :)

Great module and very useful! Here's my manual review:

1. I would recommend to wrap your css with a class with the name of your module to avoid conflict.
2. When I changed the format of the field, the url no longer turned into a link, even though we can access the page through the preview
3. Sometimes, the preview informed a "page not found" error and when I checked the link, I saw some html tags such as

.
4. For future work, I would recommend to add an option in the settings to see the preview only when hover the link.

Great work! Thanks for sharing this module with us!

Everson: I think you forgot to change the @status. Is this now RTBC after your review or are there application blockers left?

Hi @sanket

Good module, and it will be very useful. I went through your module and it works for me. Also, I agree with the points of @EversonDaSilva but I think none of them looks like application blocker to me.

Hi @klausi

Changing the status to RBTC and we can promote this module as a full project.

Thanks @Sanket for wonderful work on this.

how is it different from opengraph filter module?

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.