[D7] Entity Unique

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxnimek2704251git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi nimek,

Some of suggestions from manual review of your module are below:

1. Please use hook_help in your .module file
2. Single line space is required between each functions.
3. In .module file, line no.173, 178,183 have "';", its separate line. Join to previous line itself
4. While cloning your module, unnecessarily "2704251" folder also coming. Inside nothing is there. So please remove or clone properly..

manual review:
entity_unique_is_unique(): why would you use create_function() here? Why are you evaluating strings and cannot use EntityFieldQuery as usual? This looks very much like a code injection vulnerability, what if $entity->{$info['entity keys']['label']} contains something like "'); exec('rm -rf /');" or similar?

Why don't you just set your EntityFieldQuery up like this:

$query = new EntityFieldQuery();
  switch ($setting) {
    case ENTITY_UNIQUE_DISABLED :
      return TRUE;
    break;  
    case ENTITY_UNIQUE_PER_ENTITY_TYPE :
      $query->entityCondition("entity_type, $entity_type);

    break;
    case ENTITY_UNIQUE_PER_ENTITY_BUNDLE :
      $query->entityCondition("entity_type", $entity_type);

      $query->entityCondition('bundle',$entity->{$info['entity keys']['bundle']})\;
    break;
  }

You can achieve the same level of "dynamicness" with this approach, without having to eval() your code.

This should work just fine:

// Second part is based of defined fields/properties.
foreach ($adv_setting as $key => $field_name) {
    if ($key === $field_name) {
// Special part code for label.
        if ($field_name == $info['entity keys']['label']) {
            $query->propertyCondition($info['entity keys']['label'], $entity->{$info['entity keys']['label']});
        } // Special part code for author.
        elseif ($field_name == 'author') {
            $uid = db_select('users', 'u')->fields('u', array('uid'))->condition('name', $entity->name)->execute()->fetchField();
            $query->propertyCondition('uid', $uid );
        } // Normal for other properties.
        elseif (strpos($field_name, 'field_') === FALSE) {
            $query->propertyCondition($field_name, $entity->{$field_name});
        } // And special part for fields.
        else {
            $field_info = field_info_field($field_name);
            $target_id_label = key($field_info['columns']);
// Foreach to support multivalue fields.
            foreach ($entity->{$field_name}[LANGUAGE_NONE] as $delta => $value) {
                if (!empty($entity->{$field_name}[LANGUAGE_NONE][$delta][$target_id_label])) {
                    $query->fieldCondition($field_name, $target_id_label,$entity->{$field_name}[LANGUAGE_NONE][$delta][$target_id_label], '=');
                }
            }
        }
    }
}

I think you can replace

   $oryginal_entity = entity_load_single($entity_type, $entity_id);
    foreach (get_object_vars($oryginal_entity) as $key => $value) {
      $entity->{$key} = $value;
    }

with just

$entity = entity_load_single($entity_type, $entity_id);

One more thing I noticed: your use of drupal_static in line 167 will probably result in unexpected results when saving multiple entities during one request (for example during an import), because after checking the first entity drupal_static(__FUNCTION__) will be populated with its ID, the check in line 168 will fail, the following entities won't get checked for uniqueness and the function will just return the former ID.

I have not tested this though.

I suggest either using a string like 'entity_unique_'.entity_id($entity_type, $entity) instead of __FUNCTION__ or just dropping the drupal_static altogether.

Sure! Great work so far.

FILE: /www/2704251/entity_unique.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Patch with spelling fixes attached.

@alex.designworks : Looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Automated Review

Please check the errors in automatic reviews
http://pareview.sh/pareview/httpsgitdrupalorgsandboxnimek2704251git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) 1. As mentioned in the README.txt 'Admin > Structure > Entity type > Entity bundle' configuration page not viewable after installing the module. so please look into the issue or please update the README.txt file with proper description for how to use this module & configuration page link. you can also add configuration page link in .info file
2. (+) 1. It would be good, if you implement hook_help & hook_permission in your module.
3. Just a recommendation - Nothing

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Module looks good and working fine for me. I think we don't have any blocker, So I am marking as RTBC.

@nimek :

1: Please fix the spelling mistake in .info file.
uniqness => uniqueness
2: Please fix online review points : http://pareview.sh/pareview/httpgitdrupalorgsandboxnimek2704251git
3: Its good to have hook_help (All but the most trivial modules should implement hook_help().)

Looks good I think, so:

Thanks for your contribution, nimek!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.