Add a mail with type field

This can be done after #2708029: Rename "Contact" entity type to "Individual", #2708047: Add base fields to the "Individual" entity type

We can start working on the field type and add it to the entity in a follow-up.

Attaching an initial patch with 'mail_with_type' field type, widget, formatter, schemas and tests.

Not sure about naming... It will need some cleanup in configuration settings too.

I think such an API would basically be a replacement for getPrimaryField(), so on the entities that use it? Anything else doesn't give you method autocomplete.

1. +++ b/modules/crm_core_contact/config/schema/crm_core_contact.schema.yml
   @@ -45,3 +45,33 @@ crm_core_contact.organization_type.*:
   +field.storage_settings.mail_with_type:
   +  type: mapping
   +  label: 'Mail with type settings'
   +  mapping:
   +    mail_types:
   +      type: string
   +      label: 'Mail types'
   

   we will also need schema for the field config settings and the field value

2. +++ b/modules/crm_core_contact/src/Plugin/Field/FieldFormatter/MailWithTypeFormatter.php
   @@ -0,0 +1,44 @@
   + *   quickedit = {
   + *     "editor" = "plain_text"
   + *   }
   + * )
   + */
   +class MailWithTypeFormatter extends FormatterBase {
   

   Should we display it like \Drupal\Core\Field\Plugin\Field\FieldFormatter\MailToFormatter maybe? Or support both..

3. +++ b/modules/crm_core_contact/src/Plugin/Field/FieldType/MailWithTypeItem.php
   @@ -0,0 +1,76 @@
   +    $schema['columns']['type'] = [
   +      'type' => 'varchar',
   +      'length' => 255,
   

   We need to define what we actually store? Do we support both pre-defined and and other labels? Or only pre-defined (would be a lot easier for storage, we can make it a 32 character ascii string)

Added description for "Mail types".

Ha, didn't see #8 before uploading.

Addressed #8.1, #8.2 and schema settings for #8.3.

Changes on top of #10:
- renamed field/formatter/widget s/mail/email to be consistent with core
- made mail types list configurable
- slightly modified formatter's output
- improved test coverage

1. +++ b/modules/crm_core_contact/tests/src/Kernel/MailWithTypeItemTest.php
   @@ -2,20 +2,40 @@
   +use Drupal\Core\Language\LanguageInterface;
   ...
   +use Symfony\Component\Validator\Constraints\True;
   

   Looks like these are not used.

2. +++ b/modules/crm_core_contact/tests/src/Kernel/MailWithTypeItemTest.php
   @@ -28,28 +48,50 @@ class MailWithTypeItemTest extends KernelTestBase {
   +    $this->viewDisplay->setComponent(
   +      'field_mail_with_type', [
   +      'type' => 'email_with_type',
   +    ])->save();
   

   indentation.
   Other than that looks good.

Fixed.

Looks good to go.

Committed.

I'm a little late to the party, but I just wanted to point out that there is already a D8 version of Double Field which allows creating key-value fields. Maybe that could be useful for the social profiles and such?

Double field does not support an email field out of the box.