[D7] SCM Music Player

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Remove all the variables scm_music_player_xxx when your module has uninstall.

Refer:
https://api.drupal.org/api/drupal/modules!system!system.api.php/function...

Timeout when invoking pareview.sh for https://git.drupal.org/sandbox/abrahamso/2696995.git at http://pareview.sh/pareview/httpsgitdrupalorgsandboxabrahamso2696995git

Do you have any third-party files committed? 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access.

I'm a robot and this is an automated message from Project Applications Scraper.

Silly bot problems, sorry.

Tested the module - all works fine.
Automated code review didn't show any problems.
Manual code review - all good as well.

Couple of notes:
I would recommend changing 'true', 'false' string values in dropdowns to boolean.
E.g. instead of

'#options' => array(
  'true' => t('True'),
  'false' => t('False'),
),

it would be:

'#options' => array(
  1 => t('True'),
  0 => t('False'),
),

Also we could probably consider excluding the player from admin pages ?
e.g.

// in scm_music_player_page_build() : 
if (!path_is_admin(current_path())) {
  ...
}

Apart from that all looks good to me.
Great job!

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

1. Implementation of hook_menu should be placed above other functions in module
2. It is no need to use variable_get for 'scm_music_player_description' form item. This element won't be changed
3. Please avoid using HTML markup in your module file ('#prefix' => '<table><tr><th></th><th></th><th></th><th></th><th></th><th></th><th></th></tr><tr><td>')
4. Please use global $base_url variable instead of $GLOBALS['base_url']

It would be nice to implement block widget or field type for SCM Music Player. This will help users to control visibility of this player on different pages

Hi,

I am suggesting to update space in .module file like

   $items['admin/config/media/scm_music_player'] = array(
-    'title'           => 'SCM Music Player',
-    'description'     => 'Administer SCM Music Player',
-    'page callback'   => 'drupal_get_form',
-    'page arguments'         => array('scm_music_player_configure'),
+    'title' => 'SCM Music Player',
+    'description' => 'Administer SCM Music Player',
+    'page callback' => 'drupal_get_form',
+    'page arguments' => array('scm_music_player_configure'),
     'access callback' => 'user_access',
     'access arguments' => array('administer scm_music_player settings'),
   );

@visabhishek: I think you forgot to change the status. Is this now RTBC after your review or are there application blockers left?

Hi klausi ,

Once my suggestion accepted and applied on code then i want to review again before mark it RTBC.

Hi abrahamso,

I have downloaded https://github.com/cshum/scm-music-player/archive/github.zip and store in libraries directory.

1: Enabled libraries module then enabled scm_music_player.

Everything is fine and i am able use scm-music-player.

(Again i have disabled and un-installed both module scm-music-player and libraries)
2: This time i tried to enable scm-music-player directly , because libraries module mention in dependencies.

Now i am getting WSOD.

So again i used drush re enable scm-music-player and got following message :

drush en -y scm_music_player
WD php: Error: Call to undefined function libraries_get_libraries() in scm_music_player_requirements() (line 22 of                         [error]
/var/www/html/drupal-7.40/sites/all/modules/scm_music_player/scm_music_player.install).
Error: Call to undefined function libraries_get_libraries() in scm_music_player_requirements() (line 22 of /var/www/html/drupal-7.40/sites/all/modules/scm_music_player/scm_music_player.install).
Drush command terminated abnormally due to an unrecoverable error.  

Hope above info will help you to replicate the issue and fix.

Reviewed the latest code and I think there are no more blockers. So I think this module should be good to go. Marking it RTBC

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.