[D7] Views Title Callback

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxnikunjkotecha2693817git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@nikunjkotecha, first of all thanks for contribution!

Here is my assumptions on your code after manual review:

1. Add hook_help() to your module.

The code looks fine. Will check the functionality of the module after installation.

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Adding Pareview: Single Project Promote tag.

Thanks again!!

@th_tushar: I think you forgot to change the status. Is there any blocker left after your review or is this now RTBC?

@klausi,

I didn't change to RTBC, as I need to install and check the module functionality.

@th_tushar: that's nice if you want to do that, but not absolutely necessary. If you are confident from your code review that the applicant knows what they are doing and there are no security issues jumping out, then an RTBC is fine.

HI @nikunjkotecha,

I have installed your module to check the functionality, the module got installed without any errors.

But the functionality of the module was not working. In views configuration, I have given the custom callback function written in my custom module, saved the view. But when accessed the view, the custom title callback wasn't being called. Also when the callback didn't exists, there may be a PHP Fatal error which will break the site. This should also be handled.

While manual code review, I found that the $empty variable is being assigned a value and immediately being overridden by the boolean value. Please check the below code.

  /**
   * Inserts the code into the view display.
   */
  public function options_submit(&$form, &$form_state) {
    $new_option = $form_state['values']['title_callback'];
    switch ($form_state['section']) {
      case 'title_callback':
        $this->display->set_option('title_callback', $new_option);
        $empty = trim($new_option); - assigning a value
        $empty = empty($empty); - being overridden by boolean value.
        break;
    }
  }

Changing the status to "Needs work". Please check above issues and mark the status back to "Needs review".

Hi @nikunjkotecha,

Its working in your demo site. But not working in my drupal installation. Its a new drupal instance with just views module and your module installed. Will check once again!

And also there is a documentation https://www.drupal.org/node/1176080 demonstrating the views custom title.

Please have a look. Your module also require a additional custom module in case of any custom module not available for a custom callback function. We can use a Drupal Views hook function which will eliminate the use of your module.

@nikunjkotecha,

The intention is not to block the application but to suggest the workarounds for the module. If you still want to promote it to full project, we can do that for you.

Changing the status to RTBC.

Thanks for your contribution again!!

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2701025

Project 2: https://www.drupal.org/node/2693841

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2701025

Project 2: https://www.drupal.org/node/2693841

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.