As a follow-up to #2678872: Create AMP ad blocks, which allows us to place a single ad block, we need to allow for more ad blocks.

CommentFileSizeAuthor
#4 2683491-multiple-ad-blocks.patch5.37 KBmtift

Comments

mtift created an issue. See original summary.

mtift’s picture

Assigned: Unassigned » mtift
mtift’s picture

I've looked into multiple ways to allow placing multiple blocks with different configuration, but it seems that (unlike in Drupal 8) this is just not possible in Drupal 7. Modules such as multiblock or panels do allow placement of multiple instances of the same block, but any configuration (of the height, width, and data ad slot) would change for each block. Others I spoke to about this (such as @Dave Reid and @heyrocker) agree with this assessment.

So my plan will be to simply add more blocks. I'm thinking maybe 3 more should be sufficient for most sites. And I guess we could always add more. In other words, I'm thinking four (4) doubleclick for publishers blocks and sticking with (1) adsense block.

BTW, it is a long-term goal to add integration with modules such as dfp and adsense, but for now we would rather not add additional dependencies to this project.

mtift’s picture

Status: Active » Needs review
StatusFileSize
new5.37 KB

So basically like this

  • mtift committed d18f2f6 on 7.x-1.x
    Issue #2683491 by mtift: Allow for placing more than one ad block
    
mtift’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.