Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Mar 2016 at 05:14 UTC
Updated:
14 Jun 2016 at 01:24 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
pankajsachdeva commentedAutomated Review
Found issues in pareview.sh. Follow link: http://pareview.sh/pareview/httpgitdrupalorgsandboxiribarne2461613git
Manual Review
Can you specify that how your module is different from Node Export
Provide proper 'access callback' so that the config form can be only accessible by the admin. This cause a security velnerbility. So please update.
This review uses the Project Application Review Template.
Comment #4
pankajsachdeva commentedThanks for your contributions.I would suggest you to take a review bonus to speed up the process. Please help reviewing and put yourself on the high priority list.
Comment #5
klausiDuplication and the minor issues you found are not application blockers, anything else or should this be RTBC instead?
Comment #6
pankajsachdeva commentedHi @klausi,
I didn't find any major blocker issue. And this module works fine.
We should move it RTBC.
Comment #7
pankajsachdeva commentedComment #8
iribarne commentedI added the default branch.
As per how this module differs from the Node Export module, The Contentout module creates a CSV file preserving the node hierarchy: Fields/subfields in header row, and multi-value fields in the content cells. The hierarchy of the node is preserved so it can be easily imported using the migrate module. Examples of this were presented at DrupalCamp Atlanta last October (video: http://drupalcampatlanta.com/2015-drupalcamp-atlanta/sessions/no-code-co...), and Florida DrupalCamp (Slides: https://www.fldrupal.camp/sessions/approved/florida-drupalcamp-2016/deve...) this past weekend.
I still have some work to do on the contentout_session_streams.inc file (I already implemented the code sniffer recommendations for the contentiout.module and contentiout.info files). When I started implementing the function name changes suggested by code sniffer in the contentout_session_streams.inc file, it broke the functionality of the module. I have to investigate further before implementing the code sniffer changes suggested for the contentout_session_streams.inc file.
I will keep looking at the recommendation provided in the comments to improve this module. This is my first experience in requesting full project status for a module and I appreciate the prompt and detailed feedback form everyone.
Thank you all!
Comment #9
pankajsachdeva commentedThanks for your contributions.I would suggest you to take a review bonus to speed up the process. Please help reviewing and put yourself on the high priority list, then Git Admins will take a look at your project right away :-)
Comment #10
damienmckennaThanks for your contribution, Hector!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.