Progress towards 8.x release of Scheduler

OK, yes you are probably right. I have now added that. Progress is very good - take a look at the summary of #2594615: Automated testing in 8.x [meta]. With the exception of the API test file all of the other failing classes have patches which fix the code.

When #2655666: API Testing module - conversion to 8.x is done we can fix the final tests.

#2615592: Convert hook_help to use routes is now fixed

Fixed #2626480: scheduler/cron needs a route controller and hence also #2426627: [meta] Convert all page callbacks to routes

Moved #2655666: API Testing module - conversion to 8.x into the 'must resolve' list as it is a pre-requisite for fixing #2594615: Automated testing in 8.x [meta]

Thanks chr.fritsch. This issue is not the place to discuss the details, as here we track progress of the most important issues to get our first alpha release.

However we have got an issue for that idea already #2096585: Support for non-node entities, e.g. Media, Commerce Products, Custom 3rd-party entities and your ideas would be very welcome.

Added #2666832: Publish in the past sets date to 1970-01-01

@joekers Thinking about it again, I'm not sure #2594615: Automated testing in 8.x [meta] is technically a blocker. Each of the faults have their own issues (which are in the blockers list), and that meta issue may be used to track new tests which are not complete by the time we want to release alpha1. I've moved it back to the nice-to-have list.

Thanks for the detailed analysis. Its good to say the scenario you put yourself in, when viewing each of the issues. Very helpful.

So, in summary, your changes are:

Move into the alpha-blockers list

#2651338: Create a service for the Scheduler API
#2633870: Revisit defaults for third party settings
I'm happy with both of these suggestions. Thanks for explaining the importance of getting the new service in at the alpha stage, particularly as there is no upgrade path.

Move out of the alpha-blockers list

#2644690: Include default time processing in datetime widget for 8.x
#2655666: API Testing module - conversion to 8.x
Whilst these issues in themselves may not be blockers, they do have well tested patches which each fix current failing classes in the automated tests. Getting the current tests to all pass will help the development of every future issue we work on, as not only will we immediately see if the work breaks exitsing code, but the issue will not always be set back to 'needs work', which gives the impression that it is not ready for review. I'd be ready to commit both of these patches now, and get two more classes passing, but have refrained because it is good to get a second opinion. We do have patches for every failing class at the moment, so we can get a fully green set of tests right away, then we can concentrate on the more difficult issues.
#2666832: Publish in the past sets date to 1970-01-01 This has just been RTBC by you and committed by me.

@legovaer Why did you delete #2659824: Exclude node types that do not have scheduling enabled ? It was not in the blocker list, but that second set of issues are all the ones we would generally want to do before beta release. It's good to keep this list in view in one single place, isn't it?

No worries.
I have now moved #2633870: Revisit defaults for third party settings into the blockers list, as per Pieter's request.
Also added a new non-blocker #2667692: Re-instate field_extra_fields for 8.x

Moved #2651448: Publish and Unpublish fields are shown for users who do not have the permission to the fixed list.

Added #2652036: Field widget set incorrectly after Scheduler module re-install to the non-blockers list.

Added @ after issue number inside the [ ] to automatically display the user assigned to the issue.

#2644690: Include default time processing in datetime widget for 8.x is fixed

#2644208: Convert tokens to Drupal 8 is fixed. Thanks @joekers.

#2625572: Admin setting 'Enable content type for scheduler' is ignored is fixed
#2651344: Change unavailable_after meta tag to HTTP Header X-Robots-Tag is fixed

Added #2669164: Introduce event subscriber for the Scheduler hooks

Added #1979462: Provide API documentation
Fixed #2633870: Revisit defaults for third party settings

#2655666: API Testing module - conversion to 8.x is fixed.
#2311273: Tidy up _scheduler_publish() and _scheduler_unpublish() is fixed.

Added #2707411: Conflict between 'required publishing' and not having scheduler permission Assigned to: jonathan1055
This is not a blocker for alpha1 but should be high up in the importance list for fixing before alpha2.

Added #2365707: Missing validation allows Unpublish date to be blank to the fixed list.

Added
#2682579: Move constants out of global space into settings and schema
#2712465: 8.x test coverage Assigned to: jonathan1055
#2714135: Remove unused constants which are now in config
Fixed
#2594615: Automated testing in 8.x [meta]

Now that #2669164: Introduce event subscriber for the Scheduler hooks is complete, I have released 8.x-1.0-alpha1! Thank you Pieter, Levi, Joe and everyone else who has contributed to get us this far.

OK, so which issues shall we tackle next, for alpha2? I think #2652036: Field widget set incorrectly after Scheduler module re-install is the most important, because currently Scheduler is broken after a re-install and needs admin changes to the date widget settings. This should be fixable in code.

Added a link to the alpha1 page, which has all the issues which contributed to that release, and deleted them form this issue summary.

Moved into blockers:
#2592293: Test access to scheduled node views
#2652036: Field widget set incorrectly after Scheduler module re-install
#2682579: Move constants out of global space into settings and schema

Added:
#2416135: Provide separate tab for node scheduling
#2490570: Validate that the 'publish on' value matches the expected format
#2490578: Validate that the 'unpublish on' value matches the expected format
#2700209: Disable node access checks during cron publish/unpublish

Deleted:
#2714135: Remove unused constants which are now in config

On a separate subject, for a great alternative visual listing of the Scheduler queue take a look at https://contribkanban.com/board/scheduler

Added:
#2731587: Refresh schema and config settings after upgrading to new version
#2732223: Update readme.txt for 8.x

Fixed:
#2682579: Move constants out of global space into settings and schema
#2741263: Add composer.json file for Scheduler

Added #2751495: Uninstalling Scheduler 8.x-1.0-alpha1 deletes all fields on content types which is a major blocker

Added #2708957: SchedulerManager throws exception on receiving EntityManagerWrapper from web profiler

Fixed #2311273: Tidy up _scheduler_publish() and _scheduler_unpublish()

Added
#2754919: Add configuration link for Scheduler on modules page.
#2755665: Restore original access requirement for scheduled content overview.
#2756147: Remove @file tag docblock from .php files where the class matches the filename
#2757625: Previously passing tests now fail in Drupal 8.2 - Change assertRaw to assertText

Removed
#2652036: Field widget set incorrectly after Scheduler module re-install
#2751495: Uninstalling Scheduler 8.x-1.0-alpha1 deletes all fields on content types

Added #2771375: Use dependency injection for routeMatch() in ScheduledListAccess

Moved to Fixed
#2592293: Test access to scheduled node views
#2732223: Update readme.txt for 8.x
#2755665: Restore original access requirement for scheduled content overview.
#2767635: Scheduled content view has wrong id

Fixed
#2771613: Improvements to Scheduled Content view
#2771375: Use dependency injection for routeMatch() in ScheduledListAccess
#2659824: Exclude node types that do not have scheduling enabled

There is one problem which should be corrected before alpha2 - reported in #28 of #2651348-28: Port Rules integration for Scheduler to Drupal 8 where we get an error if the Rules module is not enabled.

Added #2790459: Move Rules integration code into a sub-module for accurate dependencies and I think this should be resolved before alpha2.

After committing #2790459: Move Rules integration code into a sub-module for accurate dependencies and #2790471: When editing a block: Fatal error: Class 'Core\RulesConditionBase' not found I have now released 8.x-1.0-alpha2

Added
#2333359: Why should unpublishing date be later than publishing one?
#2776665: Support for multi-lingual translations and differing scheduled dates
#2781433: Replace deprecated usage of Drupal::url in .install status report
#2789515: Drush task for lightweight cron
#2799095: Fix schema error in scheduled content view. Status value should be string not boolean
#2799869: Date field placeholder text doesn't reflect date format defined in admin settings - hardcode the format

Now we need to decide on the priorities for the next release. Maybe we should tackle the date entry methods (widget and text) and date validation rules.

These are now fixed:
#2700209: Disable node access checks during cron publish/unpublish
#2790459: Move Rules integration code into a sub-module for accurate dependencies
#2790471: When editing a block: Fatal error: Class 'Core\RulesConditionBase' not found
#2803049: Scheduler Module is conflicting with View_unpublished module

#2790459: Move Rules integration code into a sub-module for accurate dependencies
#2790471: When editing a block: Fatal error: Class 'Core\RulesConditionBase' not found
Removed these as they are already in the alpha2 release.

Added:
#2807081: Better label for TimestampDatetimeNoDefault widget
#2809627: Fix DefaultTime test for daylight-saving
#2824366: Move tests from /src/tests to tests/src/functional and extend BrowserTestBase instead of WebTestBase
#2831429: Date format placeholders not replaced in error message

Fixed:
#2781433: Replace deprecated usage of Drupal::url in .install status report
#2799095: Fix schema error in scheduled content view. Status value should be string not boolean

Blockers now fixed:
#2824366: Move tests from /src/tests to tests/src/functional and extend BrowserTestBase instead of WebTestBase
and #2831429: Date format placeholders not replaced in error message

Also fixed:
#2789515: Drush task for lightweight cron
#2848213: Give warning when wrong datetime field widget is set
#2861902: Fix coding standards violations in 8.x codebase
#2861909: Exit early to avoid unnecessary processing in hook_form_NODE_FORM_alter
#2867269: Replace db_select() and db_update() which are deprecated

One new non-blocker not done yet
#2868553: Fix the code to adhere to Drupal Best Practice

I think it is time for a new release. Jumping straight to rc1.

Fixed #2776665: Support for multi-lingual translations and differing scheduled dates
Added #2871164: Ensure Scheduler dates and status field have consistent translatable settings as a follow-up.

I have created 8.x-1.0-rc1

Added:
#2851618: Rules automated tests fail at D8.3 and 8.4
#2871164: Ensure Scheduler dates and status field have consistent translatable settings

Fixed:
#2873108: Amend Scheduler tests in preparation for core 8.4 change to 'save' button
#2874410: Tests with assertFieldById fail to find field at 8.3 and 8.4, ok at 8.2

Hi Pieter,

Thanks for your reply, good to hear from you! Yes I think we are generally in quite good shape for a RC2 release soon. I've been trying to work out which of the issues will be harder to resolve for our users after a 1.0 full release. The only major problem I see can is how we deal with the Scheduler text format, which is admin-defined but not actually used apart from in messages. It is causing more problems than it solves and I am tempted to remove it from the admin config page and use a standard format. The issue is #2799869: Date field placeholder text doesn't reflect date format defined in admin settings - hardcode the format and this this would also allow the validation issues to be closed. I think if we are doing this, it should be before RC2.

Jonathan

Added
#2824015: Inconsistency in "changed" timestamp when publishing in the past
#2884680: Remove field_ui dependency
#2843425: Add PRE_PUBLISH_IMMEDIATELY event to allow other modules to react before the node is published
#2890778: Populate the scheduler date fields for content created by Devel Generate
#2849490: Scheduler + Calendar module throws notice for "Undefined index: id"

Fixed
#2799869: Date field placeholder text doesn't reflect date format defined in admin settings - hardcode the format
#2629820: [meta] node edit validation

Removed
#2490570: Validate that the 'publish on' value matches the expected format
#2490578: Validate that the 'unpublish on' value matches the expected format

I have created a new release https://www.drupal.org/project/scheduler/releases/8.x-1.0-rc2 and if no new major bugs are reported in the next two months I will release 8.x-1.0

Hi Radha,
No, the integration with workbench moderation will not be part of Scheduler 8.x-1.0. See #2820026: Drupal 8 version of Scheduler Workbench Integration
Jonathan

Hello again balra06/Radha,

You have lots of requirements and ask for many things, some of which are covered in Scheduler and others can be catered for with Scheduler + Rules. Others may be provided if and when Workbench Integration gets started. This issue is specifically for tracking the progress towards our 8.x-1.0 release so please discuss those requests on other issue threads.

I know that you are new on drupal.org so I will cut you some slack, but you do not need to ask the same question on multiple issues and e-mail the project maintainers directly, when we are following the issues and are responding in good time. I am giving all my drupal work for free, spending my own spare time on it, and when you say "We need" and "We want" and "When can we expect" this type of language does not encourage me to assist you any faster ;-)

Jonathan

Added new issue #2902512: Call to a member function getThirdPartySetting() on null which is a blocker for 8.x-1.0

But we do have a bonus new feature #2916738: Enable TRAVIS build and create custom phpcs.xml

Fixed:
#2902512: Call to a member function getThirdPartySetting() on null
#2921593: Remove unrequired dependency on Action module

I think it is time for release 8.x-1.0

We now have a full release for Drupal 8 - whoop!

https://www.drupal.org/project/scheduler/releases/8.x-1.0

Fixed #2924353: Tag rules_integration tests with @group legacy

Tests now pass again at 8.5. We cannot remove the @group legacy until #2922757: Replace deprecated RouteEnhancerInterface, then remove @group legacy which may be quite some time if the new classes are not backported to 8.4 and 8.3

Thanks Chris, yes you are right. I have created #3030243: Plan for Scheduler 8.x-1.1 release

Unassigning myself from this closed issues.