As per coding standard documentation at https://www.drupal.org/coding-standards/docs#file, the @file docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#2 2756147-2.patch11.56 KBvinay15

Comments

Vinay15 created an issue. See original summary.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
StatusFileSize
new 2756147-2.patch11.56 KB

Removed @file docblocks from all .php files.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2756147-2.patch, failed testing.

jonathan1055’s picture

jonathan1055 commented
Title: Remove @file tag docblock from all the .php files. » Remove @file tag docblock from .php files where the class matches the filename

The failing tests are not the fault of this patch - it is due to a core change. Our tests will need to be adjusted, which I am working on - see #2757625: Previously passing tests now fail in Drupal 8.2 - Change assertRaw to assertText

jonathan1055’s picture

jonathan1055 commented
Status: Needs work » Needs review

Re-queued the patch, now that I have committed #2757625: Previously passing tests now fail in Drupal 8.2 - Change assertRaw to assertText.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented

Thanks :)

  • jonathan1055 committed 2a88e4f on 8.x-1.x authored by Vinay15 
    Issue #2756147 by Vinay15: Remove @file tag docblock from .php files...
jonathan1055’s picture

jonathan1055 commented
Assigned: vinay15 » Unassigned
Issue summary: View changes
Status: Needs review » Fixed

Thank you Vinay15. I checked each one, all good. Committed.

Jonathan

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.