Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#6 | 2741263-interdiff-5-to-6.txt | 1.19 KB | jonathan1055 |
#6 | 2741263-6.composer-json.patch | 1.1 KB | jonathan1055 |
|
Comments
Comment #2
Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commentedComment #3
legovaerHi,
Thanks for your work on this. Here are some suggestions:
Comment #4
Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commentedComment #5
Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commentedThank You for reviewing the patch . I have made some improvements .
Comment #6
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedHi Shreya Shetty,
Thank you for doing this, and thanks legovaer for the review. I took a look at the composer.json instructions and examples and added the user's on-screen name and user page.
I'm not sure about the standard for including non-active maintainers - Eric looked after Scheduler at 5.x & 6.x but has not contributed for three years. Also he was not the founder of this module. We have a long history - the first commits were way back in 2003, by none other than Dries Buytaert, Gábor Hojtsy and Moshe Weitzman themselves!
How do we test this new file?
Comment #7
Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commentedThe patch looks fine .
Comment #9
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedOK, I have committed the latest version, thanks Shreya.
I would still like to hear legovaer's view on testing/checking this file.
Comment #10
legovaerWe shouldn't add an automated test for this as this can be tested very easy by executing:
I've been looking into automating the test, but then we would need custom libraries defined in our composer.json file. Currently, DrupalCI does not support installation of these libraries during the testing phase. As soon as we have our module working with 8.1.x, it will become easier and we can maybe think about automating this.
Comment #11
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedNo, I did not mean we wanted an automated test, but I thought there should be some script or command to use for checking the syntax. Thanks for the info. I have not installed composer, so I guess I should go and get it and learn about it.