Project provides field and widget for Drupal integration with the structural editor gridmanager.js

Sandbox

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/uklcpsgr/2655726.git jquery_gridmanager
cd jquery_gridmanager

Comments

uklcpsgr created an issue. See original summary.

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxuklcpsgr2655726git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

uklcpsgr’s picture

Fixed coding standards errors.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

uklcpsgr’s picture

Status: Closed (won't fix) » Needs review
CRZDEV’s picture

Status: Needs review » Needs work

First of all, great work, i've tested and works perfectly, i consider this module very useful.

Automated Review

There are some simple coding style issues about not using simple quotes: link to results: http://pareview.sh/pareview/httpsgitdrupalorgsandboxuklcpsgr2655726git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (+) Do not use libraries version to recognize the foldner library, instead add into the hook_libraries_info the version as exposed into drupal documentation here And here one example link. This way it is going to be more flexible & compatible with others modules.
  2. Some simple coding style issues; check first link

This review uses the Project Application Review Template.

klausi’s picture

Priority: Major » Normal
Status: Needs work » Needs review

@CRZDEV: The libraries version and the minor coding standard issues are not application blockers, anything else that you found or should this be RTBC instead?

CRZDEV’s picture

Status: Needs review » Reviewed & tested by the community

@klausi nothing more, status updated.

mlncn’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.