Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Jan 2016 at 17:12 UTC
Updated:
14 Jun 2016 at 05:24 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxuklcpsgr2655726git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
volehFixed coding standards errors.
Comment #4
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
volehComment #6
crzdev commentedFirst of all, great work, i've tested and works perfectly, i consider this module very useful.
Automated Review
There are some simple coding style issues about not using simple quotes: link to results: http://pareview.sh/pareview/httpsgitdrupalorgsandboxuklcpsgr2655726git
Manual Review
This review uses the Project Application Review Template.
Comment #7
klausi@CRZDEV: The libraries version and the minor coding standard issues are not application blockers, anything else that you found or should this be RTBC instead?
Comment #8
crzdev commented@klausi nothing more, status updated.
Comment #9
mlncn commentedThanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.
When you create new projects (typically as a sandbox to start) you can then promote them to a full project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.