The purpose of this roadmap is to track 8.x-6.x (Foundation 6) issues, track meta issues and discuss big changes we can make in 8.x-6.x. Instead of adding issues as related tasks, please use this filter to track 8.x-6.x issues: https://www.drupal.org/project/issues/zurb_foundation?text=&status=Open&...
Stable release checklist
- Update landing page documentation. Let's be clear about what development is happening, node requirements, and upgrade notes.
- Review readme for install instructions.
- Review documentation for install instructions.
- Update maintainers and composer.json file as needed.
Meta tasks that need done before a beta release
Verify that we have feature-parity with 8.x-5.x- We've manually tested many of the 8.x-5.x features and they seem to work as expected.Keep 8.x-6.x and 8.x-5.x up to date with eachother for any shared features.I believe the plan is to stop supporting 8.x-5.x, due to a lack of resources and contribution to that branch.Investigate new Foundation 6 features and implement them where they make sense in Drupal 8.We've done some of this, and contrib can continue to innovate on more complex features.Verify that the STARTER theme still works with Foundation 6.- We've worked on a few issues about the STARTER theme and it seems to be functional now.Research and implement better build methods for the STARTER theme.- We moved to a bower/node/gulp workflow for both the base and STARTER themes.Review the codebase and release beta
June 2020 notes
Alpha6 released. Here are the issues that would get us ready for a beta release:
- Refresh the documentation and the theme landing page.
- #3051602: Gulp 4.x support
- #3109917: Upgrade to Foundation 6.7.4
- #3117547: Using the XY-grid by default
- #3090024: Fix Drupal code style issues in base theme files
- #3149507: Automated Drupal 9 compatibility fixes
Jan 2020 notes
Here is a thumbnail of key issues we are trying to look at in the last few months. Also it seems the Foundation 6.5 would be applied and then later the 6.6 will have to be checked for breaking changes. Also listing some other key issues here.
- #3029876: Upgrade to foundations-site 6.5+ and motion-ui 2.0+
- #3109917: Upgrade to Foundation 6.7.4
- #3051602: Gulp 4.x support
- #3103634: Need a default .sass-lint.yml
- #2920472: Support automatic subtheme generation in Drupal 10+ / Drush 12+. It appears Drush 9 commands should be removed and put into a helper module see zurb foundation companion
July 2017 notes
HongPong here, now aboard as co-maintainer. Just adding that we need to take some tricky decisions about whether or not to significantly alter the (alpha stage!) theme due to changes in 8.3.x theming, layouts, and in theory we should not have the code that defines the layouts, which have been spun off into foundation_layouts module.
My suggestion is to put all the available nonbreaking, minor patches onto 8.x-6.x first. Then tag release 8.x-6.0-alpha3 .
This one in particular seems important:
Then before we release 8.x-6.0-alpha4 we commit all the breaking changes and make a note of all this on the front page of the project. If the branch was in beta status, it would be a different matter. I think these are not gratuitous breaking changes, they will both make the theme more popular and maintainable, and would let us get to Foundation-Sites 6.4.1 up from 6.3.1.
Likely breaking changes are discussed in
- #2867688: compatibility problem with drupal-8.3.0 and ds-8.x-3.x
- #2871479: Upgrade from layout plugin to Layout API / Layout discovery
- #2895757: STARTER installs outdated version of Foundation (6.3.1 to 6.4.1)
- #2895755: Remove Bower and use npm instead(Fixed in 8 dev)
- #2723275: Move zurb_foundation.scss to STARTER theme.
- #2651666: Remove duplicate hard coded logo and site name in theme
I think it is legit to remove the layouts from the theme since we are still on alpha and layouts are not supposed to be included in themes, we just need to make it clear how to upgrade for people.
Comments
Comment #2
kevinquillen commentedVersion 6 looks pretty different than 5 from a tooling standpoint. I see compass stuff is still in the STARTER theme and the docs are a little outdated. We should pull the plug on the old stuff to encourage a shift to the new (Gulp, etc). Compass is still in the STARTER theme, yet not mentioned on http://foundation.zurb.com/sites/docs/installation.html.
Comment #3
samuel.mortensonComment #4
samuel.mortensonComment #5
kevinquillen commentedCould we get the new F6 logo updated on the project page?
Comment #6
kevinquillen commentedSince 6.x is still tagged alpha, is there a chance to:
Gulp
Utility / Misc
Comment #7
doostinharrell commentedIn an ideal world I would love to see full feature parity between this project and the ZURB Template (https://github.com/zurb/foundation-zurb-template). This would keep the toolstack as uniform possible between projects making it easier to incorporate updates as newer version of Foundation are available. Modeling this projects source code based on ZURB Template's file organization would also make it much easier to migrate ZURB Template prototype code into Drupal.
--
ZURB Template Features that could be integrated:
- BrowserSync
- Uglify (js minification)
- WebPack (js bundling)
- Clean CSS (css minification)
- Sourcemaps (simplify in browser review of compiled css / js)
- Imagemin (image minifcation)
- Style Sherpa (style guide generator)
--
If this is goal that current maintainers are interested in pursuing I am happy to help out. I currently use a Yeoman generator that I developed to scaffold all of our themes that is built on ZURB Template (Foundation 6.3) however I would prefer to invest myself in this project to push things forward.
Cheers!
Comment #8
florismoriceauI have a question about the use of
bowerin the Theme root, and the STARTER kit.I'm not sure why we use it.
What about removing bower to move those 2 packages into the
package.json?Thanks for your anwser.
Comment #9
kclarkson commented@doostinharrell,
I would LOVE to see that as well. Keeping the tools similar would be a huge help.
Comment #10
doostinharrell commented@FlorisMoriceau I agree that Bower dependencies should be replaced with the NPM variant. It's also good to note that the latest version of the ZURB Template ships without the need for Bower.
https://github.com/zurb/foundation-zurb-template/commit/2706b837898c0d6c...
Comment #11
hongpong commentedHm between ditching bower and the pesky matter of src/layout code issues do we have to start another branch in order to cleanly manage these issues? It seems like a lot of breaking changes would be required on 8.x-6.x otherwise, hate to say it but yeah.
Comment #12
florismoriceau@doostinharrell, I opened a new issue to talk about removing bower, and commit a patch if needed.
Comment #13
hongpong commentedComment #14
hongpong commentedComment #15
serg2 commentedHong Pong, great to see you as a new co-maintainer! Your July suggestion in the IS seems very solid.
Zurb Foundation for sites is fast moving, here is their roadmap https://github.com/zurb/foundation-sites/wiki/Project-Roadmap
I would support any changes to the subtheme process (clone rather than inherit settings/templates), having multiple zurb versions (8.x-6.3 , 8.x-6.4, 8.x-7.0), stripping out CSS or any settings which would make it easier for us to keep track of the constantly moving library.
I think (but am not 100% sure) making the subthemes standalone would mean that we could make breaking changes constantly and they would only show when a new subtheme was created, without effecting the old theme.
Comment #16
kevinquillen commentedEach major version was meant to match the major version of Foundation.
One thing I would like to see is deprecating the drush command in favor of a Drupal Console generator command. I think that would aide in subtheme creation.
Comment #17
serg2 commentedBreaking changes are fine, we are still in Alpha so anyone using the theme should expect that change will be required.
Updating the project page with this information might be a way of highlighting this.
The library we use is solid but this theme is stalling with its current release schedule.
Comment #18
kevinquillen commentedI agree with that and think we can increase the delivery speed by shedding the aging stuff like bower and drush, and consolidating it down to smaller form.
Comment #19
serg2 commentedComment #20
serg2 commentedThe dev version is getting quite far ahead of the current alpha. I cannot see any issues that have been caused by the dev, only improvements and bug fixes. I think we should roll the current dev as another release, alpha or beta.
Comment #21
hongpong commentedAgreed, I will tag 8.x-6.0-alpha3 and 7.x-5.0-rc7 . The 7.x-5.x branch had more significant commits. Thanks for all your help on this serg2!
Comment #22
serg2 commentedThere are quite a few issues in the queue which are questions about documentation. I could create formal documentation for the theme, through from installation to customising Twig templates for zurbs markup. This will close off quite a few issues and help figure out what best practice actually is. I think I might need access rights to do this, either way, if someone can point me in the right direction.
Comment #23
kevinquillen commentedHey serg, I gave your account permission to edit the project and maintain issues - is that enough to edit documentation?
Comment #24
kevinquillen commentedLet me know if you want commit access too to help out.
Comment #25
serg2 commentedThanks Kevin, that is fine for now. I found https://www.drupal.org/node/1928104 so I think it is best if I migrate that first before adding new guides focusing on 8.6. Once done I will report back her.
Comment #26
serg2 commentedI have made start to porting the old documentaio nover to the new format over at https://www.drupal.org/docs/8/themes/zurb-foundation-user-guide. It will take quite a while a while to complete.
I have asked the maintainers of the docs program how to deal with credit. For the D7 docs I copied/pasted so want list the old docs contributors but cannot see how at the moment.
Comment #27
nimzie commentedWill there be, or can there be a document on upgrading from 8.x-5 -> 8.x-6? They seem quite different in all ways and having developed all but my mobile menu to find it doesn't work in 8.x-5 w/ current version of Drupal/jQuery...
Comment #28
serg2 commented@nimzie I do not think this will be documented. There is an issue about the jquery incompatibility (#2918888: Drupal 8.4 requires jQuery 3, which no longer supports load()) but there is no easy solution provided.
Comment #29
hongpong commentednimzie maybe if you can talk a little more about which foundation features are the trickiest to deal with updating?
On a different subject I still think we should remove the layouts from the 8.x-6.x theme. #2867688: compatibility problem with drupal-8.3.0 and ds-8.x-3.x and move them to foundation_layouts #2871917: Adopt broken layouts from Zurb Foundation theme
Comment #30
hongpong commentedAlpha4 release tagged today. I think this was a good call since so many issues have been resolved. Thanks everyone for the months of work here. https://www.drupal.org/project/zurb_foundation/releases/8.x-6.0-alpha4
Comment #31
cumhur commentedDear HongPong why didin t you apply this patch zurb_foundation--starter-installs-outdated-version-of-foundation--2895757--27.patch
before release alpha 4
I installed alpha 4 still look zurb 6.3
best regards
Comment #32
mrpauldriver commented+1 for Browser Sync
Comment #33
asrobHi,
What about this issue? Can you release a new alpha?
Comment #34
sim_1It looks to me, based on the links in the issue description, that the two remaining tasks to be resolved before the next alpha are:
There are a couple other patches that are RTBC which could be included.
My hopes for the 6.x branch (maybe not for the next release, but for a stable release):
My longer wishlist for ongoing 6.x development:
Comment #35
hongpong commentedShould we get a helper module going to host the drush commands in what is now the proper way? #2920472: Support automatic subtheme generation in Drupal 10+ / Drush 12+ . I would not say that the next alpha should be dependent on this but we should figure it out in 2020.
Comment #36
asrobAs I mentioned in other issue, I've created a zurb_foundation_companion module. Co-maintainers are welcome. :)
Comment #37
hongpong commented@asrob I have added your new module to the front page with a note that it's in alpha and a link to the Drush 9 issue #2920472: Support automatic subtheme generation in Drupal 10+ / Drush 12+ which I think makes sense. Thanks so much, I took a look at it and it seems cool :)
Also it appears I have more availability this month than expected to work on the theme. So I will try to do what I can on the outstanding issues and the modules outside the theme. Happy 2020 fellow Zurbers :)
Comment #38
undersound3 commented@asrob just used your module and it works great thanks.
@HongPong First time user here of this theme. Which version is recommended to use atm?
Comment #39
hongpong commented@undersound3 I would stick with the 6.x dev version right now . https://www.drupal.org/project/zurb_foundation/releases/8.x-6.x-dev
This month I'm going to be working on the patches we have underway right now (and any evaluation you can give on them is helpful). on the other hand the dev server here seems to have just taken a nasty dive (eyeroll emoji).
Comment #40
undersound3 commented@HongPong
I certainly will be able to evaluate the patches, no problem.
About the version to use. I am developing a site atm which I am to finish end of the month. There is an alpha or beta version right now. Which is best to use for this site right now? Or do you suggest to use the dev version and patch that on the go?
Comment #41
hongpong commenteddev + patch on the go. We are trying to strip it down and push more elements (eg layouts, drush commands also apparently) out to the modules. It's been kept on alpha because we are still trying to significantly rewire this sort of thing. (and 'beta' is not supposed to make such API changes).
Comment #42
hongpong commentedComment #43
sim_1So, for an alpha6 release, can we say that the only blocking issue is #2989534: Consensus On Layouts? And to move forward with that issue we mainly need some patch testing.
Then could we start planning a beta release that incorporates the next wave of patches? Such as:
And ideally any other significant build/api/dependency changes we need to make before Drupal 9.
Comment #44
sim_1I would like to propose we make a 8.x-6.0-alpha6 release, which will have the updates and release notes captured on the current dev branch page.
What are peoples' thoughts on that idea? Are there must-haves that it doesn't make sense to release another alpha without? I think there are a lot of useful patches in the dev version right now and it would feel nice to refocus our energy on the next wave of significant changes. It also gives people a chance to update their sub-themes more incrementally with the kinds of breaking changes we're making.
Then, for a 8.x-6.0-beta1, these issues and updates seem like must-haves to me:
Comment #45
kclarkson commented@sim_1 I love it!
Comment #46
sim_1Ok, I just published an alpha6 release! First time publishing one so hopefully I did it correctly. I'll update this issue description with next steps/target issues for a beta release.
Comment #47
sim_1Comment #48
thhafner commentedWhat is the status of cutting an 8.6-beta?
Comment #49
erutan commented@thhafner, according to the roadmap it'd be bumping foundation up to either 6.6.3 or 6.7.x.
There's also a few issues that need reviewing - I'm going to try and take a look at some of them, but more eyes on that would be good.
Comment #50
steveoriol+1 for 6.7.x (last is v6.7.4)
Comment #51
d.sibaud commentedI agree with @steveoriol, 6.6.3 was released on 09/04/2020, it's two years old now, better to choose the last release
Comment #52
erutan commentedThat makes sense in that we're leaving alpha behind - it might require more work on the gulp workflow but that's better sooner than later. Aside from bumping up node requirements etc I don't think there's anything breaking looking asides from that by at the changelog: https://github.com/foundation/foundation-sites/releases
The only thing to (possibly) worry about is 6.6 will most likely break https://www.drupal.org/project/xy_grid_layouts
Comment #53
d.sibaud commentedperhaps better to involve @itothegore and @pramann so that they can be part of this change and decide whether to go along with it or not
Comment #54
thomas.frobieter@erutan why this? XY Grid is still the current foundation sites grid implementation?
Comment #55
erutan commented@thomas.frobieter: https://github.com/foundation/foundation-sites/pull/11405
I haven't actually dug into the module - it's mostly the SCSS side of things that changed, but if it uses the gutter css etc that'd break.
There's also some changes to _settings.scss etc that are minor but would need to pulled into custom subthemes: https://www.drupal.org/project/zurb_foundation/issues/3109917#comment-13...
Comment #56
erutan commentedI tossed up a quick poll for this here: https://survey.zohopublic.com/zs/GsCNn9
update: As of 2022-03-27 it's 2 no, 1 yes.
As of 2022-04-10 it's 3 no, 1 yes.
Comment #57
sim_1Two branches that have breaking changes, and then I think we're ready for beta:
- #3273854: Template updates to keep up with Core
- #3109917: Upgrade to Foundation 6.7.4
The update to the templates seems important to do before beta because we currently have really outdated field class names in our templates. And this means we diverge from core unnecessarily and it will make it harder to pull in core template logic in the future. It's a breaking change. We could modify the branch to keep the old classes too to make it less extreme.
The update to Foundation 6.7.4 is also a major update -- not because 6.7.4 is really different from what we have right now, but because I think it doesn't make sense to update it in isolation. And I really don't think we have the capacity to have a custom (drupal) build process for this theme. So that branch updates the build scripts and package.json to mirror the Foundation site template project build scripts. For the base theme this uses the foundation-sites-template because it is a fairly simple build process. For the sub-theme, I used the more robust foundation-zurb-template as reference. I also looked a little at the core Foundation build scripts to pull in linting.
Does anyone have time to comment/test/review?
Comment #58
sim_1