Review of the 7.x-1.x branch (commit c1d0f19):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...w/drupal-7-pareview/pareview_temp/age_calculator.helper_functions.inc
    ---------------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    ---------------------------------------------------------------------------
     158 | WARNING | [ ] Do not concatenate strings to translatable strings,
         |         |     they should be part of the t() argument and you
         |         |     should use placeholders
     189 | ERROR   | [x] Closing parenthesis of array declaration must be on a
         |         |     new line
    ---------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------
    
    Time: 166ms; Memory: 7.25Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Source: http://pareview.sh/ - PAReview.sh online service

CommentFileSizeAuthor
#2 coder_review-2647170-1.patch968 bytesashishdalvi

Comments

Ashish.Dalvi created an issue. See original summary.

ashishdalvi’s picture

StatusFileSize
new968 bytes

Code issue resolved. Adding patch.

kunalkursija’s picture

Hi Ashish,

The online service for pareview script ( http://pareview.sh/ ) is upgraded to use following things.
1) Drupal 8 coding standards.
2) PHPCS higher version for D8.

However the module 7.x-1.x branch follows D7 coding standards & D7 compatible PHPCS, Which is not generating any errors.

ashishdalvi’s picture

Thank you kunal for information. Please close the issue if no work is required.

ashishdalvi’s picture

Assigned: ashishdalvi » Unassigned
kunalkursija’s picture

Status: Active » Closed (fixed)