Module Description

This is module providing horizontal tabs for Form.
Project sandbox URL: https://www.drupal.org/sandbox/tabvn.drupal/2642502

Git clone:

 git clone --branch 8.x-1.0 https://git.drupal.org/sandbox/tabvn.drupal/2642502.git horizontal_tabs
cd horizontal_tabs 

Drupal core: 8.x

Thank you

Comments

PA robot’s picture

Status: Needs review » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Anonymous’s picture

beakerboy’s picture

Please update the header of this issue to help people review your project. Look at the header of other project applications to see the format and minimum information required.

A quick review using pareview shows many formatting issues.
http://pareview.sh/pareview/httpgitdrupalorgsandboxtabvndrupal2642502git

You should use an actual package name in you info.yml file, not you name.
Update the header, look at the formatting, and post back here.

id.tarzanych’s picture

I do agree with Beakerboy, you should implement description for all your methods and classes as well as for module in general. Other code parts also doesn't match coding standards. Readme file also needs to be reworked according to recommended template.

I see that you've JS code from Twitter Bootstrap project, but this file also consists formatting errors. Bootstrap code is covered with MIT license, and I am not sure if that is allowed by Drupal.org policy. Please work on that too

Anonymous’s picture

@Beakerboy ,@id.tarzanych

I have just updated the code, re-format follow drupal coding standard,

Best regards,

Toan

Anonymous’s picture

Dear There,

Any updates ?

Best regards,
Toan

beakerboy’s picture

You still have not updated the header. Nobody will review your project if they don't know where it is, or what it does.

When submitting your project application, please remember to include the following:

The name of your module or theme.
A detailed description of what it does.
A link to its sandbox project on Drupal.org.
The intended Drupal core version (eg. 6.x or 7.x)

Look at some of the other projects in the review queue or my latest submission (https://www.drupal.org/node/2632642) so see the minimum required information.

Anonymous’s picture

Module Description

This is module providing horizontal tabs for Form.
Project sandbox URL: https://www.drupal.org/sandbox/tabvn.drupal/2642502
Git clone: git clone --branch 8.x-1.0 tabvn.drupal@git.drupal.org:sandbox/tabvn.drupal/2642502.git horizontal_tabs
cd horizontal_tabs

Drupal core: 8.x

Thank you

Anonymous’s picture

Issue summary: View changes
Anonymous’s picture

Issue summary: View changes
beakerboy’s picture

The git clone command you used is YOUR clone command...you should make it the command that an anonymous user will need. I'm guessing if I used this, it would be asking for your password.

Have you read the new project guides?
https://www.drupal.org/node/539608
https://www.drupal.org/node/1187664

Anonymous’s picture

Issue summary: View changes
Anonymous’s picture

Thanks @Beakerboy

i have just updated git clone information.

 git clone --branch 8.x-1.0 https://git.drupal.org/sandbox/tabvn.drupal/2642502.git horizontal_tabs
cd horizontal_tabs 
Anonymous’s picture

Status: Needs work » Needs review
PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2642526

Project 2: https://www.drupal.org/node/2658648

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2658648

Project 2: https://www.drupal.org/node/2642526

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

avpaderno’s picture

Related issues: +#2658648: [D8] Owl carousel