Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
30 Dec 2015 at 18:14 UTC
Updated:
8 Sep 2018 at 21:28 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
Anonymous (not verified) commentedComment #4
beakerboyPlease update the header of this issue to help people review your project. Look at the header of other project applications to see the format and minimum information required.
A quick review using pareview shows many formatting issues.
http://pareview.sh/pareview/httpgitdrupalorgsandboxtabvndrupal2642502git
You should use an actual package name in you info.yml file, not you name.
Update the header, look at the formatting, and post back here.
Comment #5
id.tarzanych commentedI do agree with Beakerboy, you should implement description for all your methods and classes as well as for module in general. Other code parts also doesn't match coding standards. Readme file also needs to be reworked according to recommended template.
I see that you've JS code from Twitter Bootstrap project, but this file also consists formatting errors. Bootstrap code is covered with MIT license, and I am not sure if that is allowed by Drupal.org policy. Please work on that too
Comment #6
Anonymous (not verified) commented@Beakerboy ,@id.tarzanych
I have just updated the code, re-format follow drupal coding standard,
Best regards,
Toan
Comment #7
Anonymous (not verified) commentedDear There,
Any updates ?
Best regards,
Toan
Comment #8
beakerboyYou still have not updated the header. Nobody will review your project if they don't know where it is, or what it does.
Look at some of the other projects in the review queue or my latest submission (https://www.drupal.org/node/2632642) so see the minimum required information.
Comment #9
Anonymous (not verified) commentedModule Description
This is module providing horizontal tabs for Form.
Project sandbox URL: https://www.drupal.org/sandbox/tabvn.drupal/2642502
Git clone: git clone --branch 8.x-1.0 tabvn.drupal@git.drupal.org:sandbox/tabvn.drupal/2642502.git horizontal_tabs
cd horizontal_tabs
Drupal core: 8.x
Thank you
Comment #10
Anonymous (not verified) commentedComment #11
Anonymous (not verified) commentedComment #12
beakerboyThe git clone command you used is YOUR clone command...you should make it the command that an anonymous user will need. I'm guessing if I used this, it would be asking for your password.
Have you read the new project guides?
https://www.drupal.org/node/539608
https://www.drupal.org/node/1187664
Comment #13
Anonymous (not verified) commentedComment #14
Anonymous (not verified) commentedThanks @Beakerboy
i have just updated git clone information.
Comment #15
Anonymous (not verified) commentedComment #16
PA robot commentedProject 1: https://www.drupal.org/node/2642526
Project 2: https://www.drupal.org/node/2658648
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #17
PA robot commentedProject 1: https://www.drupal.org/node/2658648
Project 2: https://www.drupal.org/node/2642526
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #18
avpaderno