[D7] Commerce RajaOngkir

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2629388

Project 2: https://www.drupal.org/node/2130235

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxiS2629378git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
Yes: It follows code and API guidelines.

@ItangSanjana: Here's some code review:
In commerce_rajaongkir.module lines 64 and 89

  foreach ($couriers_get as $key => $value) {
    if ($value !== 0) {
      foreach ($services_get[$key] as $key => $value) {
        $shipping_services[$key] = array(
          'title' => $value['service'],

These nested foreach loops are using the same $key => $value variable names, so the second $key => $value is overwriting the first. This might be deliberate on your part, but the code is more readable if you use variable names that convey meaning.

Removing all reviews from the issue summary that only repeat the automated reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

1. commerce_rajaongkir_commerce_shipping_service_info_alter(): why is this alter hooks necessary? Why can't you do that in commerce_rajaongkir_commerce_shipping_service_info()? Please add a comment in code.
2. "drupal_set_message(t('@notice', array('@notice' => $cost['rajaongkir']['status']['description'])), 'warning', FALSE);": that is not a useful error message. Use something like "Shipping web service is currently not available: @notice". Same for '@error', which is not useful on its own.
3. Function doc blocks: you are just repeating the function name with "Returns commerce_rajaongkir_services_get()." for example. That is not useful at all, you should briefly describe what the function is used for, parameters and return values. See https://www.drupal.org/coding-standards/docs#functions

But otherwise looks good to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Naveen as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, Itang!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

ha, "ht emight" should be "he might", fixed above!