Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This module is designed to associate group specific menus with a group when using the Group module.
Sandbox URL: https://www.drupal.org/sandbox/mike.davis/2558059
Git:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/mike.davis/2558059.git group_menu
cd group_menu
Manual Reviews:
Comments
Comment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmikedavis2558059git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
mike.davis commentedThe errors and warnings found by the bot have been all dealt with now
Comment #4
fishfree commentedI manually read the code, and learned a lot! A wonderful module, I have used it in my site, no problem. A diligent author, almost every issue can be replied and be fixed as soon as possible. This module will accelerate the use of the more flexible Group module.
Comment #5
mike.davis commented@fishfree, many thank for the comments and glad that you liked the module :)
Comment #6
johnennew commentedBeen using this module for over 6 months - its ready for the big time!
The maintainer has been responsive to all issues raised.
Comment #7
tessa bakkerHi mike.davis,
Found 2 issues, rest seems oke.
Major:
Group context-module dependency is missing, see groupmenu.module:1013Minor: context is missing in jQuery selector:
Drupal.groupMenu.populateParentSelect is a gray area for me.
Comment #8
mike.davis commentedHi Tessa,
Thanks for your feedback.
The module 'Group Context' and another sandbox module that I have which I looking at providing to the Group module as well. I will have a look at this but I guess the best thing would be to remove this for the time being.
I have had a look over the Javascript and I am wondering if this is actually needed anymore, so I am going to look at removing this for the time being.
Once I have updated the module I will update the status and would appreciate your review again.
Thanks
Mike
Comment #9
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #10
mike.davis commentedI have updated the module now to not have any reliance on the groupcontext module and I have updated the Javascript to use the context in the jQuery selector.
Please review the latest updated version.
Comment #11
Rustan commentedWhen the module is activated it provides a Config link from the module overview, which leads to /admin/config
It should go somewhere, possibly /admin/structure/groupmenu but this is almost empty and has no information about what to do with it after install.
It took me a while to figure out that you have to go to blocks to activate each individual group menu, as an administrator, to get them to show up. Being able to set them to be activated by default, and a region where they are added, would make this much more useful in a dynamic setup where users are not site admins.
Great addition to Group, looking forward to using and contributing to this!
Comment #12
klausi@Rustan: I think you forgot to change the status. Is this now RTBC after your review or are there any application blockers left that must be fixed?
Comment #13
Rustan commented@klausi: I have no power to approve, sorry if my comments were made incorrectly here. I found the module and wanted to help get it approved.
Comment #14
tessa bakkerAs Rustan explains, config url isn't correct in group_menu.info
Also groupmenu_block_view() doesn't return always an array, although this isn't required with PHP it is good practice.
I think this is RTBC when both issues are fixed.
Comment #15
mike.davis commentedHi @Rustan, thanks for spotting this. I have had a look at the config URL and it seems that the one in the module info file was pointing to an incorrect URL (looks like an old URL that must have been changed) which was then defaulting to /admin/config. I have updated this URL in the module info file to point to the correct URL now, which is /admin/config/system/groupmenu.
@Tessa, I have also updated the return values from the function groupmenu_block_view() to always be an array.
Many thanks for you feedback.
Comment #16
hesnvabr commentedI found 3 issues:
1) Quotes mistakes in js file i.e String must use single quotes.
2) Codespell like one code file i found is won't actuall spell is wont that we use in code.
http://pareview.sh/pareview/httpgitdrupalorgsandboxmikedavis2558059git this link helps you to check the issues in group_menu
3) In an info file you exceed 80 characters in a single line.But in actual it should not be exceed 80 characters.
Comment #17
klausi@pranavbabbar: minor coding standard errors are not application blockers, anything else that you found or should this be RTBC instead?
Comment #18
tessa bakker@mike.davis, Nice work!
If you want to speed up the approvement progress, try to review 3 or more projects and add your review links in the issue summary.
Comment #19
mike.davis commentedThanks @Tessa. OK, I'll have a look at the list and write some reviews :)
Comment #20
mike.davis commentedHi @pranavbabbar, thanks for highlighting these - despite running the module through Pareview several time on previous occasions it hasn't found these issues :).
I have corrected the Javascript ones and updated the module file with a couple of additional coding standard fixes.
Comment #21
mike.davis commentedComment #22
mlncn commentedThanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.
When you create new projects (typically as a sandbox to start) you can then promote them to a full project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.