Project name: Guru
Drupal Version: [D8]

This Project is a very simple gulp-based Theme Workflow Using

  • KSS-Node Styleguides
  • Singularity GS like in Omega4
  • SCSS Linting

and much more. Please check the Project page to read the up-to-date Details/Features list

https://www.drupal.org/sandbox/digitaldonkey/2599668

git clone --branch 8.x-1.x http://git.drupal.org/sandbox/digitaldonkey/2599668.git guru

Comments

digitaldonkey created an issue. See original summary.

PA robot’s picture

Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdigitaldonkey2599668git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

digitaldonkey’s picture

Priority: Normal » Major
Status: Needs work » Needs review

Fixed pareview.sh Issues and refactored branch naming.

joelpittet’s picture

Assigned: digitaldonkey » Unassigned
Issue summary: View changes

Fixed clone branch

joelpittet’s picture

Fixed clone branch

digitaldonkey’s picture

Status: Needs review » Active
joelpittet’s picture

Status: Active » Needs review

We want this in needs review status to get someone to RTBC it.

digitaldonkey’s picture

Issue summary: View changes
benellefimostfa’s picture

Status: Needs review » Needs work

You have many issues related to coding standards.

You can see the full report her:
http://pareview.sh/pareview/httpgitdrupalorgsandboxdigitaldonkey2599668git

Using the coder module will help you a lot to fix this kind of issues.
https://www.drupal.org/project/coder

klausi’s picture

Priority: Major » Normal
Status: Needs work » Needs review
Issue tags: -[D8]

Minor coding standard problems are not application blockers, anything else that you found or should this be RTBC instead?

benellefimostfa’s picture

I did a manual review, and it's ok for me.

digitaldonkey’s picture

I did par-review some while ago and now there seem to be higher demands.

Actually besides behaviours.js all coding standard violations are coming from external NON-PHP Files (KSS-Node Template files).
Any suggestions how to handle this? Is there a way to exclude specific files?

digitaldonkey’s picture

rlhawk’s picture

Status: Needs review » Reviewed & tested by the community

The code looks good to me.

digitaldonkey’s picture

mlncn’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

apaderno’s picture

Title: Guru Theme [D8] - A styleguide based theme workflow » [D8] Guru