Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Project name: Guru
Drupal Version: [D8]
This Project is a very simple gulp-based Theme Workflow Using
- KSS-Node Styleguides
- Singularity GS like in Omega4
- SCSS Linting
and much more. Please check the Project page to read the up-to-date Details/Features list
https://www.drupal.org/sandbox/digitaldonkey/2599668
git clone --branch 8.x-1.x http://git.drupal.org/sandbox/digitaldonkey/2599668.git guru
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdigitaldonkey2599668git
Fixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
digitaldonkey CreditAttribution: digitaldonkey commentedFixed pareview.sh Issues and refactored branch naming.
Comment #4
joelpittetFixed clone branch
Comment #5
joelpittetFixed clone branch
Comment #6
digitaldonkey CreditAttribution: digitaldonkey commentedComment #7
joelpittetWe want this in needs review status to get someone to RTBC it.
Comment #8
digitaldonkey CreditAttribution: digitaldonkey commentedComment #9
benellefimostfa CreditAttribution: benellefimostfa commentedYou have many issues related to coding standards.
You can see the full report her:
http://pareview.sh/pareview/httpgitdrupalorgsandboxdigitaldonkey2599668git
Using the coder module will help you a lot to fix this kind of issues.
https://www.drupal.org/project/coder
Comment #10
klausiMinor coding standard problems are not application blockers, anything else that you found or should this be RTBC instead?
Comment #11
benellefimostfa CreditAttribution: benellefimostfa commentedI did a manual review, and it's ok for me.
Comment #12
digitaldonkey CreditAttribution: digitaldonkey commentedI did par-review some while ago and now there seem to be higher demands.
Actually besides behaviours.js all coding standard violations are coming from external NON-PHP Files (KSS-Node Template files).
Any suggestions how to handle this? Is there a way to exclude specific files?
Comment #13
digitaldonkey CreditAttribution: digitaldonkey commentedComment #14
rlhawkThe code looks good to me.
Comment #15
digitaldonkey CreditAttribution: digitaldonkey commentedComment #16
mlncn CreditAttribution: mlncn at Agaric commentedThanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.
When you create new projects (typically as a sandbox to start) you can then promote them to a full project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Comment #19
apaderno