Many tests are now failing with UpdatePathTestBase, could be a core regression.

The first test we see this issue with is https://dispatcher.drupalci.org/job/default/37588/consoleFull
The most recent is https://dispatcher.drupalci.org/job/default/37779/consoleFull

Total of 22 tests have failed like this today..

Its possible that something in #2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways is causing some kind of racey condition to happen.

CommentFileSizeAuthor
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.revert-2382675.patch20.57 KBalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#6 2616808.no-change.patch193 bytesalexpott
#4 2616808.no-change.patch193 bytesalexpott
#4 2616808.revert-2382675.patch20.57 KBalexpott

Comments

Mixologic created an issue. See original summary.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented

I've seen very similar failures before. I have a link to https://www.drupal.org/pift-ci-job/66336 in my email from Oct. 30:

Drupal core test fail! 8.0.x-dev on PHP 5.6 & MySQL 5.5

14,277 pass, 2 fail
View at https://www.drupal.org/pift-ci-job/66336

Failing tests:

Update.Drupal\system\Tests\Update\UpdatePathTestBaseFilledTest

✗ runUpdates
  fail: [Browser] Line 253 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  GET http://localhost/checkout/update.php/start?id=4&op=do_nojs returned 0
(0 bytes).

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.anotherblock:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_account_menu:settings.cache failed with:
missing schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_breadcrumbs:settings.cache failed with:
missing schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_content:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_footer:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_help:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_login:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_main_menu:settings.cache failed with:missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_messages:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_powered:settings.cache failed with: missing
schema
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2616808.revert-2382675.patch20.57 KB
new 2616808.no-change.patch193 bytes

Let's test the hypothesis that this is caused by #2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

So the only other time this shows up in any of the log files prior to today is back in october 29th-30th:

Fyi you can go from the full console back to drupal.org from the very top of the output

Patch tests:

https://dispatcher.drupalci.org/job/default/29248 (https://www.drupal.org/pift-ci-job/65190)
https://dispatcher.drupalci.org/job/default/29276 (https://www.drupal.org/pift-ci-job/65248)
https://dispatcher.drupalci.org/job/default/29560 (https://www.drupal.org/pift-ci-job/65532)
https://dispatcher.drupalci.org/job/default/29645 (https://www.drupal.org/pift-ci-job/65748)
https://dispatcher.drupalci.org/job/default/29709 (https://www.drupal.org/pift-ci-job/65874)
Branch tests
https://dispatcher.drupalci.org/job/php5.6_mysql5.5/168/ (https://www.drupal.org/pift-ci-job/65632)
https://dispatcher.drupalci.org/job/php5.6_mysql5.5/169/ (https://www.drupal.org/pift-ci-job/66336 the one xjm linked)

DrupalCI definitely had a lot of other problems on the 29th/30th, so I wouldnt be surprised if those jobs are red herrings. nevertheless they failed in the same way so can provide some clues, hopefully, to what is causing this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.no-change.patch193 bytes
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB
new 2616808.revert-2382675.patch20.57 KB

A different approach...

The last submitted patch, 6: 2616808.no-change.patch, failed testing.

The last submitted patch, 6: 2616808.no-change.patch, failed testing.

The last submitted patch, 6: 2616808.no-change.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

I've reverted #2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways - tentatively marking as rtbc. Let's see how things work out.

The last submitted patch, 4: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Fixed

Yep this revert has fixed the random error.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

@Mixologic:

@berdir wrote in #2382675-48: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways:

[...] something like this [...] smells like a segfault [and] is also always very system/version specific. Any chance that we can get at the apache/php logs of the failing containers somehow?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Title: Slew of random test failures with UpdatePathTestBase » Slew of random test failures with UpdatePathTestBase when using is_subclass_of() in ContentEntityType::checkStorageClass()
Priority: Critical » Normal
Status: Fixed » Postponed

Reopening this and repurposing it to figure out what's actually wrong with the is_subclass_of() check, see #2382675-50: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

It's probably a PHP 5.5 bug, see #2496337-84: [plach] Testing issue. What patch version are the 5.5 tests running on?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Postponed » Postponed (maintainer needs more info)

#2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways was committed again, no way to reproduce it locally, not even via a DrupalCI testbot, so setting to maintainer needs more info.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Bug Smash Initiative

Reviewed this as part of the Bug Smash Initiative, will reach out to @plach on slack to see if this can now be closed.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

It seems this was never reproduced since then, closing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Crediting people