Slew of random test failures with UpdatePathTestBase when using is_subclass_of() in ContentEntityType::checkStorageClass() [#2616808]

Many tests are now failing with UpdatePathTestBase, could be a core regression.

The first test we see this issue with is https://dispatcher.drupalci.org/job/default/37588/consoleFull
The most recent is https://dispatcher.drupalci.org/job/default/37779/consoleFull

Total of 22 tests have failed like this today..

Its possible that something in #2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways is causing some kind of racey condition to happen.

Comment	File	Size	Author
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.revert-2382675.patch	20.57 KB	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 1 fail
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#6	2616808.no-change.patch	193 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
#4	2616808.no-change.patch	193 bytes	alexpott
#4	8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass PHP 5.6 & MySQL 5.5 14,406 pass PHP 7 & MySQL 5.5 14,396 pass PHP 5.5 & SQLite 3.8 14,393 pass PHP 7 & SQLite 3.14 14,383 pass PHP 5.5 & PostgreSQL 9.1 14,396 pass PHP 7 & PostgreSQL 9.1 14,386 pass
#4	2616808.revert-2382675.patch	20.57 KB	alexpott
#4	8.0.x: PHP 5.5 & MySQL 5.5 1 fail PHP 5.6 & MySQL 5.5 14,406 pass PHP 7 & MySQL 5.5 14,396 pass PHP 5.5 & SQLite 3.8 14,393 pass PHP 7 & SQLite 3.14 14,383 pass PHP 5.5 & PostgreSQL 9.1 14,396 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 November 2015 at 23:52

Mixologic created an issue. See original summary.

Comment #2

Mixologic

He/Him/His

English

Portland, OR

CreditAttribution: Mixologic at Drupal Association commented 16 November 2015 at 23:55

Issue summary:

View changes

Comment #3

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 17 November 2015 at 02:09

I've seen very similar failures before. I have a link to https://www.drupal.org/pift-ci-job/66336 in my email from Oct. 30:

Drupal core test fail! 8.0.x-dev on PHP 5.6 & MySQL 5.5

14,277 pass, 2 fail
View at https://www.drupal.org/pift-ci-job/66336

Failing tests:

Update.Drupal\system\Tests\Update\UpdatePathTestBaseFilledTest

✗ runUpdates
  fail: [Browser] Line 253 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  GET http://localhost/checkout/update.php/start?id=4&op=do_nojs returned 0
(0 bytes).

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.anotherblock:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_account_menu:settings.cache failed with:
missing schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_breadcrumbs:settings.cache failed with:
missing schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_content:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_footer:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_help:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_login:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_main_menu:settings.cache failed with:missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_messages:settings.cache failed with: missing
schema

  fail: [Other] Line 269 of
core/modules/system/src/Tests/Update/UpdatePathTestBase.php:
  Schema key block.block.bartik_powered:settings.cache failed with: missing
schema

Comment #4

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 17 November 2015 at 02:13

Status:

Active

» Needs review

File	Size
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail PHP 5.6 & MySQL 5.5 14,406 pass PHP 7 & MySQL 5.5 14,396 pass PHP 5.5 & SQLite 3.8 14,393 pass PHP 7 & SQLite 3.14 14,383 pass PHP 5.5 & PostgreSQL 9.1 14,396 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass PHP 5.6 & MySQL 5.5 14,406 pass PHP 7 & MySQL 5.5 14,396 pass PHP 5.5 & SQLite 3.8 14,393 pass PHP 7 & SQLite 3.14 14,383 pass PHP 5.5 & PostgreSQL 9.1 14,396 pass PHP 7 & PostgreSQL 9.1 14,386 pass

Let's test the hypothesis that this is caused by #2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways

Comment #5

Mixologic

He/Him/His

English

Portland, OR

CreditAttribution: Mixologic at Drupal Association commented 17 November 2015 at 02:46

So the only other time this shows up in any of the log files prior to today is back in october 29th-30th:

Fyi you can go from the full console back to drupal.org from the very top of the output

Patch tests:

https://dispatcher.drupalci.org/job/default/29248 (https://www.drupal.org/pift-ci-job/65190)
https://dispatcher.drupalci.org/job/default/29276 (https://www.drupal.org/pift-ci-job/65248)
https://dispatcher.drupalci.org/job/default/29560 (https://www.drupal.org/pift-ci-job/65532)
https://dispatcher.drupalci.org/job/default/29645 (https://www.drupal.org/pift-ci-job/65748)
https://dispatcher.drupalci.org/job/default/29709 (https://www.drupal.org/pift-ci-job/65874)
Branch tests
https://dispatcher.drupalci.org/job/php5.6_mysql5.5/168/ (https://www.drupal.org/pift-ci-job/65632)
https://dispatcher.drupalci.org/job/php5.6_mysql5.5/169/ (https://www.drupal.org/pift-ci-job/66336 the one xjm linked)

DrupalCI definitely had a lot of other problems on the 29th/30th, so I wouldnt be surprised if those jobs are red herrings. nevertheless they failed in the same way so can provide some clues, hopefully, to what is causing this.

Comment #6

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 17 November 2015 at 09:33

File	Size
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.no-change.patch	193 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,406 pass
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail
2616808.revert-2382675.patch	20.57 KB
8.0.x: PHP 5.5 & MySQL 5.5 1 fail

A different approach...

Comment #7

17 November 2015 at 10:08

The last submitted patch, 6: 2616808.no-change.patch, failed testing.

Comment #8

17 November 2015 at 10:10

The last submitted patch, 6: 2616808.no-change.patch, failed testing.

Comment #9

17 November 2015 at 10:14

The last submitted patch, 6: 2616808.no-change.patch, failed testing.

Comment #10

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 17 November 2015 at 10:47

Status:

Needs review

» Reviewed & tested by the community

I've reverted #2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways - tentatively marking as rtbc. Let's see how things work out.

Comment #11

17 November 2015 at 11:03

The last submitted patch, 4: 2616808.revert-2382675.patch, failed testing.

Comment #12

17 November 2015 at 11:24

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #13

17 November 2015 at 11:24

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #14

17 November 2015 at 11:24

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #15

17 November 2015 at 11:24

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #16

17 November 2015 at 11:25

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #17

17 November 2015 at 11:25

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #18

17 November 2015 at 11:25

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #19

17 November 2015 at 11:26

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #20

17 November 2015 at 11:26

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #21

17 November 2015 at 11:26

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #22

17 November 2015 at 11:27

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #23

17 November 2015 at 11:27

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 6: 2616808.revert-2382675.patch, failed testing.

Comment #24

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 17 November 2015 at 11:58

Status:

Needs work

» Fixed

Yep this revert has fixed the random error.

Comment #25

plach

he/him

Italian

Venezia

CreditAttribution: plach as a volunteer commented 17 November 2015 at 22:23

@Mixologic:

@berdir wrote in #2382675-48: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways:

[...] something like this [...] smells like a segfault [and] is also always very system/version specific. Any chance that we can get at the apache/php logs of the failing containers somehow?

Comment #26

plach

he/him

Italian

Venezia

CreditAttribution: plach as a volunteer commented 18 November 2015 at 01:29

Title:	Slew of random test failures with UpdatePathTestBase	» Slew of random test failures with UpdatePathTestBase when using is_subclass_of() in ContentEntityType::checkStorageClass()
Priority:	Critical	» Normal
Status:	Fixed	» Postponed

Reopening this and repurposing it to figure out what's actually wrong with the is_subclass_of() check, see #2382675-50: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways.

Comment #27

plach

he/him

Italian

Venezia

CreditAttribution: plach as a volunteer commented 18 November 2015 at 10:18

It's probably a PHP 5.5 bug, see #2496337-84: [plach] Testing issue. What patch version are the 5.5 tests running on?

Comment #28

plach

he/him

Italian

Venezia

CreditAttribution: plach as a volunteer commented 18 November 2015 at 23:05

Status:

Postponed

» Postponed (maintainer needs more info)

#2382675: hook_entity_create() affects the data of new translations of existing entities in unexpected and undocumented ways was committed again, no way to reproduce it locally, not even via a DrupalCI testbot, so setting to maintainer needs more info.

Comment #29

18 November 2015 at 23:05

Version:

8.0.x-dev

» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #30

18 November 2015 at 23:05

Version:

8.1.x-dev

» 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #31

18 November 2015 at 23:05

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #32

18 November 2015 at 23:05

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #33

18 November 2015 at 23:05

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #34

18 November 2015 at 23:05

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #35

18 November 2015 at 23:05

Version:

8.6.x-dev

» 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #36

18 November 2015 at 23:05

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.