[D7-D8] Validators

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Some minor errors in coding.
FILE: /var/www/drupal-7-pareview/pareview_temp/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 107 characters
14 | WARNING | Line exceeds 80 characters; contains 100 characters
33 | WARNING | Line exceeds 80 characters; contains 109 characters
34 | WARNING | Line exceeds 80 characters; contains 93 characters
50 | WARNING | Line exceeds 80 characters; contains 144 characters
----------------------------------------------------------------------

FILE: ...w/drupal-7-pareview/pareview_temp/tests/drupal_symfony_validator.test
---------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
---------------------------------------------------------------------------
13 | ERROR | [x] Missing function doc comment
24 | ERROR | [ ] Visibility must be declared on method
| | "testNonExistingConstraint"
32 | ERROR | [ ] Visibility must be declared on method
| | "testNoViolations"
40 | ERROR | [ ] Visibility must be declared on method "testOptions"
58 | ERROR | [ ] Visibility must be declared on method
| | "testBasicConstraints"
106 | ERROR | [ ] Visibility must be declared on method
| | "testStringConstraints"
154 | ERROR | [ ] Visibility must be declared on method
| | "testNumberConstraints"
174 | ERROR | [ ] Visibility must be declared on method
| | "testComparisonConstraints"
180 | ERROR | [ ] Doc comment short description must be on a single line,
| | further text should be a separate paragraph
182 | ERROR | [ ] Visibility must be declared on method "testReturnArray"
214 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: ...pal-7-pareview/pareview_temp/tests/drupal_symfony_validator.form.test
---------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
3 | ERROR | [x] Missing class doc comment
5 | ERROR | [x] Missing function doc comment
13 | ERROR | [x] Missing function doc comment
13 | ERROR | [ ] Visibility must be declared on method "setUp"
16 | ERROR | [x] Whitespace found at end of line
17 | ERROR | [x] Missing function doc comment
17 | ERROR | [ ] Visibility must be declared on method
| | "testSingleValidator"
18 | ERROR | [x] Perl-style comments are not allowed; use "// Comment"
| | instead
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

@pranavbabbar: I think you forgot to change the status. Is this now RTBC after your review or are there application blockers left?

I have looked over and tested the D8 version of the module at it is a pretty simple but solid concept with good code. I think this is RTBC.

I am not sure about the style or usage of the README.md file. There is no official guide for using README.md files, there is only a recommendation for README.txt. Personally, I am also using README.md files and just try to match the general style guide for README.txt

I did recommend that the module's namespace be changed from drupal_symfony_validator to just validators to match #validators property that is being added to form elements.

Once this module is a full project I am going add examples and support for it to YAML form module. #2693855: Validators

Please don't RTBC your own issues, see the workflow https://www.drupal.org/node/532400

Ah sorry, overlooked that.

yay! good to see it's RTBC. Great to get this in. Thanks to @legovaer for the great work and follow ups...

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Yay! Thank you @mlncn!!!