[D7] Bulk File Upload

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I personally think that this name will make others confused with Bulk Media Upload

Also, I recommend you rewrite line 99-113 in bulk_file_upload.admin.inc with ArchiveZip class provided by Drupal core.

    $zip = new ZipArchive();
    $zip = zip_open(drupal_realpath($file->uri));
    $count = 0;
    $invalid_files = '';
    if (is_resource($zip)) {
      while ($zip_entry = zip_read($zip)) {
        $file_name = zip_entry_name($zip_entry);
        $extension = explode(".", $file_name);
        $extension = end($extension);
        if (!in_array($extension, $setting_extension)) {
          $count++;
          $invalid_files[] = $count . ')' . $file_name;
        }
      }
      $zip = zip_close($zip);

I also don't know the difference between this module and the Pack & Upload module. It seems this module can not meet the requirement of "No duplication".

While duplication is bad and we should let applicants know it is not an application blocker.

Hello mehul.shah,

Following are the points which i could find while reviewing your module

1. There is a warning on line 37 of bulk_file_upload.admin.inc you can put one check isset($form_state['values']) to avoid this warning
2. This permission "bulk_file_upload" on line 26 in bulk_file_upload.module is not being used anywhere.
3. Line 100 is throwing warning when you select folder for upload
4. On line 144 in submit handler you have hardcoded "You can check uploaded file using @path_check + image name" but i uploaded pdf file so it was bit confusing either you can use file instead of image name or any meaningful sentence

@Mehul,

I observed few points while reviewing:

1. Line no. 81 in admin file, it would be better if you use check_plain function. otherwise it'll create security threat.
2. Mention module requirement in README file.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @mehul.shah,
you have a git errors:

The following git branches do not match the release branch pattern, you should remove/rename them. See https://www.drupal.org/node/1015226

remotes/origin/7.x-1.1

https://pareview.sh/node/1148

@sjpagan: the git branch name alone is surely not an application blocker. Anything else that you found or should this be RTBC instead?

Hi, @klausi,
sorry I promise to be more careful :-) ...

I found little problem on your code, at line 90 in file bulk_file_upload.admin.inc, @mehul.shah may include if foldere exist. See image

Hi mehul,

Add type of menu in hook_menu.
Add hook_help in module file.

@mehul.shah

1. When I am tying to upload wrong file its show me following warning and notice.

    The specified file Rajesh Uppadhay.mp4 could not be uploaded. Only files with the following extensions are allowed: zip.
    Notice: Trying to get property of non-object in bulk_file_upload_form_validate() (line 107 of /var/www/html/drupal7-1/sites/all/modules/bulk_file_upload/bulk_file_upload.admin.inc).
    Warning: zip_open(): Empty string as source in bulk_file_upload_form_validate() (line 107 of /var/www/html/drupal7-1/sites/all/modules/bulk_file_upload/bulk_file_upload.admin.inc).

Hi @mehul.shah

I have reviewed your project and found some issues as:

• 1. On pareview.sh, showing an error in it.
  

  FILE: /root/repos/pareviewsh/pareview_temp/bulk_file_upload.module
  --------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  --------------------------------------------------------------------------
  14 | ERROR | [x] Case breaking statements must be followed by a single
  | | blank line
  --------------------------------------------------------------------------
  PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  --------------------------------------------------------------------------

• 2. On project page only single line description is mention even the above description is not so clear. Description should be more specific and clear with Requirements, Project Page link, pareview.sh review link, steps and configuration etc. Please follow this link for help: https://www.drupal.org/node/2839511

Individual Account

Yes

No duplication

No, see https://www.drupal.org/project/pack_upload

Master Branch

Yes

Licensing

Yes

3rd party assets/code

Yes

README.txt/README.md

Yes

Code long/complex enough for review

Yes

Secure code

Yes

Coding style & Drupal API usage

No

1. + Public filesystem should not be assumed to be `sites/default/files`, the `public://` stream wrapper should be used instead.
2. Hook menu callback should be `drupal_get_form()` for the admin page, instead of using an intermediate `page callback`

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxmehulshah2001972git

I'm a robot and this is an automated message from Project Applications Scraper.

Mostly fine, But fix One Bug . See attachment

1. Is this a duplication of the existing Bulk File Upload module? The application links to a sandbox and the code appears to be quite different. At the very least, there appears to be a namespace conflict.

2. Is there a reason you've set the menu item as a MENU_CALLBACK instead of a MENU_NORMAL_ITEM? As it stands, after enabling the module, the configuration link does not appear on the Config page, and there is no link under the Media subsection, which is very confusing.

3. There is a typo in bulk_file_upload.admin.inc on line 41.
'#description' => t('Use comma to separate multiple extensstion<br/> Ex. jpg,jpeg'),
should be
'#description' => t('Use commas to separate multiple extensions<br/> Ex. jpg,jpeg'),

4. I was unable to get this module to work. When attempting to upload my zip file, I got the following fatal error:

Error: [] operator not supported for strings in bulk_file_upload_form_validate() (line 107 of /.../sites/all/modules/bulk_file_upload/bulk_file_upload.admin.inc).

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.