[D7] Velaro Chat

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjtuttle872584927git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello, I reviewed you module and found list of defects:

1) Please, follow drupal coding standards https://www.drupal.org/coding-standards
Examples: http://i.imgur.com/xZRDOM7.jpg

2) PA review test have failed http://pareview.sh/pareview/httpgitdrupalorgsandboxjtuttle872584927git

Please, recheck.

Manual Review

Individual user account

Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation.

Master Branch

Follows the guidelines for master branch.

Licensing

Follows the licensing requirements.

3rd party assets/code

Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Follows the guidelines for project length and complexity.

Secure code

Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (+) Please provide some inline documentation for velaro_chat_form() and velaro_chat_page_alter()
2. The whole file is indented one level
3. ...]

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Two more major points:

- Can you provide an option to include the scripts from lines 205 & 206 locally as opposed to loading them from https://galleryuseastprod.blob.core.windows.net? Maybe as a checkbox in your admin settings.

- Please delete the variables you used when uninstalling the module in hook_uninstall()

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello. I've reviewed your module.

I found some issues:
1) Error in line 8, you missed comment symbol.
2) No semicolon at the end of the line.
3) Bad style usage css. Read https://api.drupal.org/api/drupal/includes!common.inc/function/drupal_ad... Better style using arrays for add css.
4) Why you use <div> in drupal forms?
5) Use form validation https://api.drupal.org/api/drupal/developer!topics!forms_api_reference.h...
6) You used PHP curl queries. Recommended use https://api.drupal.org/api/drupal/includes!common.inc/function/drupal_ht....
7) Use arrays for adding all js such as line 145 in your code.
8) Read https://www.drupal.org/node/304258#drupal-settings (variables, Drupal.behaviors)

Automated Review

The automated review of your project by PAReview (ESLint) has found some issues with your JavaScript. As coding standards make sure projects are coded in a consistent style we ask you to please have a look at the report and try to fix them.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Where do the JavaScript files in the repo come from? Are they your own work, or are they written by somebody else?

Project page

No. Please take a moment to make your project page follow the Project page template and it may be a good idea to also read tips for a great project page.
In particular, you should add the section "Dependencies". This module depends on SaaS delivered by Velaro. This dependency, and costs must be disclosed on the project page.

README.txt/README.md

(*) No: Does not follow the guidelines for in-project documentation and/or the README Template.
You've named the file "readme.txt". The standard name is "README.txt" or "README.md" and writing "readme" in lower case makes our robot sad.
You should use "README.md" if the intent is make use of MarkDown formatted text. The text almost looks nice when run through MarkDown filter, but not quite.
However, the major failing of the README is that it consists entirely of marketing blurb and does not tell the user how to install, configure or use the module.
Your README should also instruct reviewers in how to get a free Velaro account for review purposes.
Please take a moment to make your README.txt follow the guidelines for in-project documentation and the README.txt Template.

Code long/complex enough for review

No: Does not follows the guidelines for project length and complexity as it only has 4 PHP functions. Tagging with "Single project promote".

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) hook_uninstall is located in the main module file. It should go in .install
2. (*) hook_uninstall implies the existence of a content type named velaro_chat, but I can't find any code in your project to create it.
3. (*) It creates the collowing db variables: velaro_chat_api_key velaro_chat_page_assignments velaro_chat_password velaro_chat_site_identifier velaro_chat_username velaro_chat_vm_enabled, but does not delete them upon uninstall.
4. (*) Markup in chat form not translatable
5. (*) The intended meaning of form element velaro_chat_link_button is unclear. Pressing the button produces no feedback.
6. (+) Please follow Drupal coding standards: https://www.drupal.org/coding-standards. In particular, pay attention to function declarations and placement of opening curly bracket.
7. All calls to variable_get is missing the second argument (making it NULL by default). I think it is better to supply a value.

The starred items (*) above are big issues and warrant the application going back to Needs Work. Items marked with a plus sign (+) should be addressed before a stable project release, but does not block the project from being promoted to a full project. The rest of the comments are only recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.