A module that exports the watchdog log messages from the watchdog table
and inserts them in jira, as issues.

The user navigates on admin/config/services/jira_rest, where he completes the
form fields with the jira username, password and URL.

Then in admin/config/development/logging/jira, chooses what message type jira
will send after cron runs and how many will check. Its important, also to fill
the project KEY (not the TITLE). When the cron runs, the module will check if
the log message exists. If it exists, with resolution as "Unresolved", the
module doesn't creates the issue or if exists, with resolution as "Resolved",
then creates again this issue as "Unresolved" in jira.

The link of my project: https://www.drupal.org/sandbox/giannisverginis/2568771

git link: http://cgit.drupalcode.org/sandbox-GiannisVerginis-2568771/

git clone: git://git.drupal.org/sandbox/GiannisVerginis/2568771.git

Comments

giannisverg created an issue. See original summary.

Jverg’s picture

Jverg commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxGiannisVerginis256877...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Jverg’s picture

Jverg commented
Issue summary: View changes
Jverg’s picture

Jverg commented
Issue summary: View changes
Jverg’s picture

Jverg commented
Issue summary: View changes
Jverg’s picture

Jverg commented
Status: Needs work » Needs review
sch4lly’s picture

sch4lly commented
Status: Needs review » Needs work

Manual Review

Individual user account
Follows the guidelines for individual user accounts.
No duplication
Does not cause module duplication and/or fragmentation.
Master Branch
Follows the guidelines for master branch.
Licensing
Follows the licensing requirements.
3rd party assets/code
Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Follows the guidelines for project length and complexity.
Secure code
Meets the security requirements.
Coding style & Drupal API usage
  1. (+) It seems you are not deleteing all of your variables in hook_uninstall() (for example "jira_rest_username")

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Also, please add a git clone link to your application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review

That sounds like a good improvement, but is surely not an application blocker. Anything else that you found or should this be RTBC instead?

sch4lly’s picture

sch4lly commented
Status: Needs review » Reviewed & tested by the community

Apart from the missing variable_deletes, no,

Jverg’s picture

Jverg commented

Hi i have made some changes if i push them will review my module again plz?
and variables such as jira_rest_username and jira_rest_password is taken from jira_rest module.

Jverg’s picture

Jverg commented
Issue summary: View changes
Jverg’s picture

Jverg commented
Issue summary: View changes
Jverg’s picture

Jverg commented
Assigned: Unassigned » Jverg
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Jverg » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go also to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.