[D7] Slack Update Notifier

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmartynmcwhirter256830...

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account

Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation.

Master Branch

Follows the guidelines for master branch.

Licensing

Follows the licensing requirements.

3rd party assets/code

Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Follows the guidelines for project length and complexity.

Secure code

Meets the security requirements.

Coding style & Drupal API usage

I saw no coding style or Drupal API issues.

The module installed as expected and functions as described. No installation or functional problems found. I thought it was rather clever and I'm will likely us it when it's approved.

This review uses the Project Application Review Template.

Please don't RTBC your own issues, see the workflow: https://www.drupal.org/node/532400

Hi Martynmcwhirter

Thanks for your contribution, I found the following issues/suggestion in your module.

Issues
1. The variables used in your application like (slack_update_notifier_webhook_url, slack_update_notifier_sitename, slack_update_notifier_channel etc) are not getting removed from the variable table if we uninstall the module. You can create a install file in your module and can use variable_del() where required.
2. Few minor spacing issue are there in your .module file, you can check http://pareview.sh to fix those.

Suggestion
1. Please elaborate a bit more about "Webhook URL" used in the configuration filed either in help text or in module's README.txt file.

Manual Review
Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets] the security requirements.
Coding style & Drupal API usage
[Yes: Seems] to have no apparent coding style or Drupal API issues.
As mentioned before, installation is smooth and functionality does what it promised. Keep up.
This review uses the Project Application Review Template.
Disclaimer: This is my first official review so please excuse any discrepancies, including formatting issues.

Your code is very concise and well documented, good work. From my manual review I could identify some minor issues.

1. I missed the "Implements hook_x()" comments, such as in slack_update_notifier_menu (add Implements hook_menu().) and slack_update_notifier_cron (Implement hook_cron().). Please add those, this helps to identify these functions.

2. I was able to save the form with junk text. Can you do some sort of verification for the Webhook URL?

3. There are some fields that I wouldn't qualify as required, such as message. You could also add some default values in variable_get.
e.g., variable_get('slack_update_notifier_username', 'drupal_update_bot');

This is a very heplful module, great work!

@Everson: I think you forgot to change the status. Is this now RTBC after your review or are there application blockers left?

@klausi: I didn't find any blockers, it's good to go for me.

Thanks for your contribution! Please clean up the noted issues in the last reviews. Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.