in system.install the code seems to be invalid:

    $form['cron_url'] = array(
      '#markup' => '<p>' . t('To run cron from outside the site, go to <a href="!cron">!cron</a>', array('!cron' => $this->url('system.cron', array('key' => $this->state->get('system.cron_key')), array('absolute' => TRUE)))) . '</p>',
    );

To run cron from outside the site, go to <a href="/drupal8/cron/[KEY]?0%5Babsolute%5D=1">/drupal8/cron/[KEY]?0%5Babsolute%5D=1</a>

CommentFileSizeAuthor
#25 2563757-25.patch995 bytesjofitz
#25 interdiff-2563757-23-25.txt847 bytesjofitz
#23 2563757-23.patch983 bytesjofitz
#12 external_cron_url_on-2563757-12.patch1.61 KBcilefen
#12 interdiff-2563757-12.txt775 bytescilefen
#12 external_cron_url_on-2563757-12-TEST.patch897 bytescilefen
#2 Issue-2563757-by-hass-Cron-URL-on-status-page-is-not.patch955 byteshass

Comments

hass created an issue. See original summary.

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new Issue-2563757-by-hass-Cron-URL-on-status-page-is-not.patch955 bytes
hass’s picture

hass commented
Issue summary: View changes
hass’s picture

hass commented
Related issues: +#2551725: Remove system_requirements() SafeMarkup::set() use with 'value' key

.

hass’s picture

hass commented
Related issues: -#2551725: Remove system_requirements() SafeMarkup::set() use with 'value' key +#2296929: Remove system_requirements() SafeMarkup::set() use
hass’s picture

hass commented
Title: Cron URL on status page is not absolute » External cron URL on status page is not absolute
cilefen’s picture

cilefen commented
Issue tags: +Needs tests

Is there a simpletest assert to test if a URL is absolute? I think this feature is important enough to regression test if we can.

hass’s picture

hass commented

I have not found any assert message tests for the reports page. Do you know where these are located?

cilefen’s picture

cilefen commented

I just reinstalled from HEAD and the page source shows an absolute URL.

<p>To run cron from outside the site, go to <a href="http://localhost/drupal8x/cron/1euTIONtUYMmjtMgPUFRqIZoWE-RBRJb414pnpUmACNjpsj4PbaCjTQWyA_plmD1iMaPoeuhwQ">http://localhost/drupal8x/cron/1euTIONtUYMmjtMgPUFRqIZoWE-RBRJb414pnpUmACNjpsj4PbaCjTQWyA_plmD1iMaPoeuhwQ</a></p>

cilefen’s picture

cilefen commented

Oh, wait, #9 was on admin/config/system/cron. This is a different path. Ignore #9.

cilefen’s picture

cilefen commented

Drupal\system\Tests\System\StatusTest

cilefen’s picture

cilefen commented
Issue tags: -Needs tests
StatusFileSize
new external_cron_url_on-2563757-12-TEST.patch897 bytes
new interdiff-2563757-12.txt775 bytes
new external_cron_url_on-2563757-12.patch1.61 KB

The last submitted patch, 12: external_cron_url_on-2563757-12-TEST.patch, failed testing.

mgifford queued 12: external_cron_url_on-2563757-12.patch for re-testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs review » Needs work

The patch doesn't apply anymore.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue tags: +Needs reroll
jofitz’s picture

jofitz
he/him
commented
Version: 8.6.x-dev » 8.7.x-dev
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2563757-23.patch983 bytes

The change has since been implemented, but the test has not, so here it is.

Status: Needs review » Needs work

The last submitted patch, 23: 2563757-23.patch, failed testing. View results

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2563757-23-25.txt847 bytes
new 2563757-25.patch995 bytes

Use a string not the url object.

Status: Needs review » Needs work

The last submitted patch, 25: 2563757-25.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

Closing as outdated since the message update has since been implemented. And the current tests seem to cover that. If you still feel this is an issue please reopen