Sandbox project:

https://www.drupal.org/sandbox/cityreader/2545780

Description:

The Clientside Validation Commerce module only provides some UX improvement (https://www.drupal.org/node/1775750) when you use clientside_validation module in the Drupal commerce site. It is
useful to fix the UX bug when you happen to use clientside_validation module in the checkout pages of Drupal Commerce site. It hides processing icon when
form validation in JavaScript is failed and show processing icon when that Javascript validation is successful.

Module dependencies

Clone repository

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/cityreader/2545780.git clientside_validation_commerce
cd clientside_validation_commerce

How to test
1. Install distro commerce kickstart to build a test site.
2. Install clientside_validation module.
3. Clone and install the module from admin/modules.
4. Create a user account and login.
5. Add a product to shopping cart.
6. Goto checkout page and DO NOT FILL required field.
7. Click continue button and see error message from clientside_validation module.
8. Check continue button is enabled.
9. Fill in all required field and click continue button again.
10. Check continue button is disabled with visible spinning icon.
11. User is redirected to the next page.

Comments

eric.chenchao created an issue. See original summary.

PA robot’s picture

PA robot commented
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2546444

Project 2: https://www.drupal.org/node/2506013

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxcityreader2545780git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Vijaya Sankar N’s picture

Vijaya Sankar N commented
Vijaya Sankar N’s picture

Vijaya Sankar N commented

It seems you have some of indent errors in commerce_clientside_validation.js file. In addition make your Document comment short and crispy as possible in one line.

change this from:

/**
 * @file
 * Javascript for the enable and disable continue button in Commerce
 * checkout pages.
 */

to something like this:

/**
 * @file
 * Javascript for Commerce checkout.
 *
 * Javascript for the enable and disable continue button in Commerce
 * checkout pages.
 */

Reference:
http://pareview.sh/pareview/httpgitdrupalorgsandboxcityreader2545780git

Set a default branch for your project as mentioned here:
https://www.drupal.org/node/1659588

PA robot’s picture

PA robot commented
Status: Needs work » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2506013

Project 2: https://www.drupal.org/node/2546444

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Closed (duplicate) » Needs work

Hi Eric,
I'm interested in using this module if you're still interested in getting it approved.

Looks like you're on a long and arduous path to becoming a module maintainer - thank you for sticking with it and thank you for your Drupal.org contributions!

eric.chenchao’s picture

eric.chenchao commented
Status: Needs work » Needs review

Hi @aaronbauman, thanks for reporting that major issue of this module. Now this module has been rename to 'clientside_validation_commerce' as you suggested.

Yeah, applying for a module maintainer is a long journey for myself. But I won't give up:D Hope we can get this module approved!

eric.chenchao’s picture

eric.chenchao commented
Title: Commerce Clientside Validation » Clientside Validation Commerce
Issue summary: View changes
eric.chenchao’s picture

eric.chenchao commented

@Vijaya Sankar N, I have also updated comment in js :D

visabhishek’s picture

visabhishek commented
Title: Clientside Validation Commerce » [D7] Clientside Validation Commerce
Issue summary: View changes
warped’s picture

warped commented
Status: Needs review » Postponed (maintainer needs more info)

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

I am closing this application for the lack for replies. I take the OP just needed to be able to promote the project.