Description

Shoprocket module integrates the Shoprocket shopping cart service into Drupal. Shoprocket exists as a SaaS extension that can be used to manage the purchasing of e-commerce products through a separate service, mitigating requirement for internally developed e-commerce functionality. It contains all of the purchasing process within modal boxes and integrates well with Stripe and Paypal on its service. The products are managed directly through the Shoprocket dashboard and therefore do not necessarily need to exist as separate nodes or entities on Drupal.

We are anticipating that this will be of great use for users who want to quickly integrate e-commerce into existing sites, or users that wish to maintain products separately to their site mitigating risk of keeping and purchasing or user accounts inside Drupal. It also works particularly well on mobile apps.

Project Page

The project page is currently https://www.drupal.org/sandbox/willhallonline/2537680

Git Clone

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/willhallonline/2537680.git shoprocket

Comments

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Vignesh Puliyadi Raja’s picture

Vignesh Puliyadi Raja commented

Automated Review

No issues in pareview.

Manual Review

Individual user account
Yes follow the guideline

No duplication
Yes follow the guideline

Master Branch
Yes follow the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes follow the guideline

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

1. Add success message using hook_install () when your module has installed.
2. Add configure link in .info file
3. you have dependencies listed in your .info file.

ajay_reddy’s picture

ajay_reddy
Location Fremont, California, USA
commented

Hello
Update your git clone as
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/willhallonline/2537680.git shoprocket

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts
No duplication
[Yes: Does not cause]
Master Branch
[Yes: Follows]
Licensing
[Yes: Follows]
3rd party assets/code
[Yes: Follows]
README.txt/README.md
[Yes: Follows]
Code long/complex enough for review
[Yes: Follows]
Secure code
[Yes: Meets the security requirements]
Coding style & Drupal API usage
[Yes: Follows]

No issues in pareview.sh http://pareview.sh/pareview/httpgitdrupalorgsandboxwillhallonline2537680git

Vignesh Puliyadi Raja’s picture

Vignesh Puliyadi Raja commented
Status: Needs review » Needs work
willhallonline’s picture

willhallonline
Primary language English
Location Cambridge, UK
commented
Issue summary: View changes
willhallonline’s picture

willhallonline
Primary language English
Location Cambridge, UK
commented

As to comment (https://www.drupal.org/node/2538998#comment-10153698):
1. Added success message using hook_enable() when module is installed
2. Added configure link in .info file
3. Dependencies listed in .info file

willhallonline’s picture

willhallonline
Primary language English
Location Cambridge, UK
commented
Status: Needs work » Needs review

As to comment (https://www.drupal.org/node/2538998#comment-10153698):
1. Added success message using hook_enable() when module is installed
2. Added configure link in .info file
3. Dependencies listed in .info file

cferthorney’s picture

cferthorney
he/them
Primary language English
Location Huntingdon, UK
commented

Manual review:

Well documented module and well coded. My only thought is whether shoprocket_cart_id should be sanitised any further? If it is supposed to be plain text (And why would it be anything else) why not add a check_plain() in to your variable_set, as off memory variable_set doesn't automatically sanitise. If no else agrees happy to mark RTBC, leaving as needs review for now.

willhallonline’s picture

willhallonline
Primary language English
Location Cambridge, UK
commented

Thanks @cferthorney. Have added validation and better descriptions to the cart_field on the block config. Not sure that it needs a check_plain and can't see many instances where that is used elsewhere?

rbrown_1193@hotmail.com’s picture

rbrown_1193@hotmail.com commented

Looks good to me. Installed on fresh version of Drupal 7.38, no problems to report, cart appears straight away once the block is positioned and the Shoprocket ID provided.

willhallonline’s picture

willhallonline
Primary language English
Location Cambridge, UK
commented
Status: Needs review » Fixed
cferthorney’s picture

cferthorney
he/them
Primary language English
Location Huntingdon, UK
commented
Status: Fixed » Reviewed & tested by the community

Marking as RTBC as per module review guidelines

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I am going to update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thank you to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.