Project page: https://www.drupal.org/sandbox/redhead/2535100
Project name: Masquerade float block (masquerade_float_block)
Git repository: http://git.drupal.org/sandbox/redhead/2535100.git
Pareview: http://pareview.sh/pareview/httpgitdrupalorgsandboxredhead2535100git

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/redhead/2535100.git masquerade_float_block
cd masquerade_float_block

Drupal version: 7,
Dependencies: masquerade

Description:
This is simple module which works with Masquerade module and provides float
Masquerade block.
The module is useful when you use panels everywhere on the site and
features to export the configuration.
With this module you don't need to care about removing Masquerade
block from panel configuration for stage or live environment.

Initial block position is left top, but it can be changed by dragging the block.
Position will be remembered.

Block inherits all settings from native Masquerade block.

USAGE:
Once module was enabled, you will see the Masquerade block on the
left top position.

Also, you can control appearing of the Masquerade block in three ways:

  1. With admin UI: navigate to admin/config/people/masquerade/float-block (People > Masquerade > Float block) , enable or disable float block.
  2. pass the ?mfb_show parameter in GET request to 1 or 0
    ex.: http://site.com?mfb_show=1 - enable Masquerade block
    - 1 enable Masquerade block on all pages
    - 0 disable Masquerade block on all pages
  3. set the "masquerade_float_block_visible" variable to 1 or 0.
    ex.: variable_set('masquerade_float_block_visible', 1) - enable Masquerade block
    in settings.php:
    $cong['masquerade_float_block_visible'] = 0 - disable Masquerade block

My manual Reviews of other projects:

  1. https://www.drupal.org/node/2536388#comment-10138882
  2. https://www.drupal.org/node/2533002#comment-10139092
  3. https://www.drupal.org/node/2536988#comment-10139252
  4. https://www.drupal.org/node/2193367#comment-10145420
  5. https://www.drupal.org/node/2155969#comment-10145608
  6. https://www.drupal.org/node/2536388#comment-10176466

Other reviews:
https://www.drupal.org/node/2333893#comment-10131198

Comments

ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 as a volunteer and at Innoraft commented
Status: Needs review » Needs work

Hi dstorozhuk,
Please fix your git clone command. It requires your password. You can get correct command from the version control tab of your sandbox project

ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 as a volunteer and at Innoraft commented
Assigned: dstorozhuk » Unassigned

And no need of assigning it to yourself.

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes

@ajalan065 Done, thanks.

ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 as a volunteer and at Innoraft commented
Status: Needs work » Needs review
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes

Update Pareview.

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
PA robot’s picture

PA robot CreditAttribution: PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

babusaheb.vikas’s picture

babusaheb.vikas CreditAttribution: babusaheb.vikas commented

1) It would be better if your *.info file looks like:

name = Masquerade float block
description = This module provides the float masquerade block to switch users
core = 7.x
package = development
dependencies[] = masquerade

2) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented

@babusaheb.vikas,

#1 is done, thanks for your review. But can you, please, explain reasons why #1 (or provide a link)? Here Writing module .info files (Drupal 7.x) I can't find any directions about the .info file content order. Only table of content, but there is nothing about following the order.

#2 done.

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue tags: +PAreview: review bonus
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes

Update the description.

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
Torvald’s picture

Torvald CreditAttribution: Torvald commented

Hi dstorozhuk,

Pareview / Coder review: OK

I have reviewed your project.
I think everythink works fine.
Good work!

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented

Ok, thanks.
Waiting for review from Drupal admins.

rutel95’s picture

rutel95
Primary language Russian
Location Wroclaw
CreditAttribution: rutel95 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

My suggestions:
1) After turning on the float block is disclosed, make it better shut.
2) By default it would be better to open the popup float block was in the middle
3) It is better to hide the float block from admin / * pages
And so all good for me.

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented
Issue summary: View changes
dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
CreditAttribution: dstorozhuk as a volunteer commented

@ruslan_03492, thanks for your review.
Let's wait for other users feedback. If I get same opinion as your from one more user, I will perform changes in behaviour you suggest.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I am going to update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thank you to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.