Fix pareview.sh warnings before 7.x stable release [#2533162]

http://pareview.sh/pareview/httpgitdrupalorgprojectprotectednodegit

Git errors:

There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732

Review of the 7.x-1.x branch (commit a686414):

Remove "version" from the ./protected_node.info file, it will be added by drupal.org packaging automatically.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

DrupalPractice has found some issues with your code, but could be false positives.


FILE: ...rupal-7-pareview/pareview_temp/tests/protected_node.private_file.test
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
 38 | WARNING | There must be no blank line following an inline comment
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.module
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------
 510 | WARNING | Messages are user facing text and must run through t()
     |         | for translation
 694 | WARNING | Unused variable $info.
 785 | WARNING | Unused variable $style_name.
 874 | WARNING | Unused variable $num_updated.
 896 | WARNING | Unused variable $nid.
 910 | WARNING | Unused variable $nid.
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.settings.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------
 417 | WARNING | #options values usually have to run through t() for
     |         | translation
 418 | WARNING | #options values usually have to run through t() for
     |         | translation
 419 | WARNING | #options values usually have to run through t() for
     |         | translation
 761 | WARNING | Messages are user facing text and must run through t()
     |         | for translation
 779 | WARNING | Messages are user facing text and must run through t()
     |         | for translation
 872 | WARNING | Messages are user facing text and must run through t()
     |         | for translation
---------------------------------------------------------------------------

Time: 775ms; Memory: 17.75Mb

DrupalSecure has found some issues with your code (please check the Writing secure core handbook).



FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.settings.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 81 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 46 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 49 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
 51 | WARNING | Returning unsanitized input from  set from variable_get
--------------------------------------------------------------------------

Time: 896ms; Memory: 18.25Mb

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.fork.inc
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
 6 | ERROR | Doc comment short description must be on a single line,
   |       | further text should be a separate paragraph
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/tests/protected_node.test
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
 5 | ERROR | [x] Doc comment short description must start with a capital
   |       |     letter
 6 | ERROR | [ ] Doc comment short description must be on a single line,
   |       |     further text should be a separate paragraph
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: ...rupal-7-pareview/pareview_temp/tests/protected_node.private_file.test
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
 38 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.install
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
 110 | ERROR | [x] Closing parenthesis of array declaration must be on a
     |       |     new line
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.module
---------------------------------------------------------------------------
FOUND 15 ERRORS AND 4 WARNINGS AFFECTING 18 LINES
---------------------------------------------------------------------------
    5 | ERROR   | [x] Doc comment short description must end with a full
      |         |     stop
   10 | ERROR   | [ ] Doc comment short description must be on a single
      |         |     line, further text should be a separate paragraph
   12 | ERROR   | [x] Doc comment long description must end with a full
      |         |     stop
   18 | ERROR   | [ ] Doc comment short description must be on a single
      |         |     line, further text should be a separate paragraph
   20 | ERROR   | [x] Doc comment long description must end with a full
      |         |     stop
   26 | ERROR   | [ ] Doc comment short description must be on a single
      |         |     line, further text should be a separate paragraph
   28 | ERROR   | [x] Doc comment long description must end with a full
      |         |     stop
   41 | ERROR   | [ ] Doc comment short description must be on a single
      |         |     line, further text should be a separate paragraph
   49 | ERROR   | [ ] Doc comment short description must be on a single
      |         |     line, further text should be a separate paragraph
   63 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
      |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
      |         |     "* Implements hook_foo_BAR_ID_bar() for
      |         |     xyz-bar.html.twig.", or "* Implements
      |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
   74 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
      |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
      |         |     "* Implements hook_foo_BAR_ID_bar() for
      |         |     xyz-bar.html.twig.", or "* Implements
      |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
  110 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
      |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
      |         |     "* Implements hook_foo_BAR_ID_bar() for
      |         |     xyz-bar.html.twig.", or "* Implements
      |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
  161 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
      |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
      |         |     "* Implements hook_foo_BAR_ID_bar() for
      |         |     xyz-bar.html.twig.", or "* Implements
      |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
  230 | ERROR   | [ ] Parameter comment must end with a full stop
  412 | ERROR   | [x] Separate the @param[in] and @param[in,out] sections
      |         |     by a blank line.
  803 | ERROR   | [x] Separate the @param[in,out] and @return sections by
      |         |     a blank line.
  810 | ERROR   | [ ] Function return type is not void, but function is
      |         |     returning void here
 1295 | ERROR   | [ ] Parameter comment must start with a capital letter
 1295 | ERROR   | [ ] Parameter comment must end with a full stop
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.settings.inc
---------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------
  10 | ERROR | Doc comment short description must be on a single line,
     |       | further text should be a separate paragraph
  16 | ERROR | Doc comment short description must be on a single line,
     |       | further text should be a separate paragraph
  22 | ERROR | Doc comment short description must be on a single line,
     |       | further text should be a separate paragraph
 875 | ERROR | Missing short description in doc comment
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.admin.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
 89 | WARNING | Only string literals should be passed to t() where
    |         | possible
---------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 21 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 1.64 secs; Memory: 20Mb

Source: http://pareview.sh/ - PAReview.sh online service

Comment	File	Size	Author
#7	protected_node-travis_ci-2533162-7.patch	2.37 KB	Grimreaper
#7
#6	protected_node-travis_ci-2533162-6.patch	2 KB	izus
#6
#5	protected_node-travis_ci-2533162-5.patch	2.09 KB	izus
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

izus CreditAttribution: izus commented 14 July 2015 at 19:16

Title:

Fix pareview.sh warnings before 7.x satble release

» Fix pareview.sh warnings before 7.x stable release

Comment #2

izus CreditAttribution: izus commented 14 July 2015 at 19:17

Issue summary:

View changes

Comment #3

15 July 2015 at 09:31

Grimreaper committed 21d7bf7 on 7.x-1.x

Issue #2533162 by Grimreaper: Fix pareview.sh warnings.

Comment #4

Grimreaper

French

France 🇫🇷

CreditAttribution: Grimreaper as a volunteer commented 15 July 2015 at 09:51

Status:

Active

» Needs work

Hello,

I fixed almost all the warnings except:

Git errors:

There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732

I found a release connected to the master branch https://www.drupal.org/node/130915. I edited it but I still have the following error :

drupal7/sites/all/modules/protected_node (7.x-1.x)$ git push origin :master
florenttorregrosa@git.drupal.org's password: 
remote: The branch 'master' is identified as an official development branch on Drupal.org, and therefore cannot be deleted.
remote: error: hook declined to update refs/heads/master
To florenttorregrosa@git.drupal.org:project/protected_node.git
 ! [remote rejected] master (hook declined)
error: impossible de pousser des références vers 'florenttorregrosa@git.drupal.org:project/protected_node.git'

Review of the 7.x-1.x branch (commit 21d7bf7):

Remove "version" from the ./protected_node.info file, it will be added by drupal.org packaging automatically.

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).


FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.admin.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
 89 | WARNING | Only string literals should be passed to t() where
    |         | possible
---------------------------------------------------------------------------

I don't know how to handle that case.


Time: 1.63 secs; Memory: 20Mb

DrupalSecure has found some issues with your code (please check the Writing secure core handbook).



FILE: /var/www/drupal-7-pareview/pareview_temp/protected_node.settings.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 81 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 52 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 55 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
 57 | WARNING | Returning unsanitized input from  set from variable_get
--------------------------------------------------------------------------

Time: 900ms; Memory: 18.5Mb

There are three blank lines in a t() that made all those warnings and I don't know how to handle that.

Thanks for any help.

Comment #5

izus CreditAttribution: izus commented 15 July 2015 at 10:35

Status:

Needs work

» Needs review

File	Size
protected_node-travis_ci-2533162-5.patch	2.09 KB

dear automated tests, what's your feeling ?

Comment #6

izus CreditAttribution: izus commented 15 July 2015 at 10:53

File	Size
protected_node-travis_ci-2533162-6.patch	2 KB

well actually is is a default value of a variable.
the br stuff won't work on it
here is a new try
actually variable may also be translated with i18n variable, and this is a user defined content...

Comment #7

Grimreaper

French

France 🇫🇷

CreditAttribution: Grimreaper as a volunteer commented 15 July 2015 at 12:17

File	Size
protected_node-travis_ci-2533162-7.patch	2.37 KB

Ok,

I put the string on the same line otherwise we would have the warning to not concatenate in t().

I thought to use PHP_EOL for compatibility but I could not figure out how to use it with t().

For the t($language...): ok, but I wonder it was here it was for a reason no?

Comment #8

izus CreditAttribution: izus commented 15 July 2015 at 12:22

nope, i think the t in language was just because of some old code there. go for t() in one line with no concatenation, that's the recommanded way !
and please tell testbot we don't have all the day for this !^^

Comment #9

15 July 2015 at 12:35

Grimreaper committed c5fecb8 on authored by izus

Issue #2533162 by izus, Grimreaper: Fix pareview.sh warnings before 7.x...

Comment #10

Grimreaper

French

France 🇫🇷

CreditAttribution: Grimreaper as a volunteer commented 15 July 2015 at 12:38

Status:

Needs review

» Needs work

Merged. Thanks.

Now, only stays the master branch.

Comment #11

izus CreditAttribution: izus commented 16 July 2015 at 11:14

Status:

Needs work

» Closed (fixed)

master branch is user in https://www.drupal.org/node/130915
this issue is already fixed apart from that master trouble.
this doesn't prevent us from a beta or rc publish

i created the followup in the infrastructure issue queue to get some help from some git super power users ! #2534444: please delete the master branch on the protected_node module