Remove SafeMarkup::set in ViewsUIController::reportFields()

Related: #2505931: Remove SafeMarkup::set in ViewListBuilder

No longer blocked, though the discussion in #2501975: Determine how to update code that currently joins strings in SafeMarkup::set() might be valuable to identify the best solution in this case.

Postponed for real on #2505931: Remove SafeMarkup::set in ViewListBuilder. Whatever pattern we find works there can most likely be used here as well.

This may work once #2505931-170: Remove SafeMarkup::set in ViewListBuilder is in.

#2505931: Remove SafeMarkup::set in ViewListBuilder just landed :)

Perfect!

This needs to be updated still

Ah yes, that was wrong

@pjonckiere did you test #15? Against HEAD? Because it works fine for me:

I'm not sure about this needing automated tests, the item_list already has test coverage so asserting for the correct output of that theme function (ie. a <ul class="comma-list"> etc.) in every single caller seems a bit redundant? We also can't assert for the comma list as it's CSS based, so this would need to be tested manually.

If anything asserting that the field list is not empty would be a nice to have for the future?

Ah, that makes sense, thanks!

Added that test and this should fix the issue from #18

I just manually tested myself and it didn't have the CSS issue (Firefox). Do you have the same problem in the comma separated item lists on admin/structure/views? Which browser was this?

+++ b/core/modules/views_ui/src/Tests/ReportFieldsTest.php
@@ -0,0 +1,60 @@
+    $field_storage = FieldStorageConfig::create([
+      'field_name' => 'field_test',
+      'type' => 'integer',
+      'entity_type' => 'entity_test',
+    ]);
+    $field_storage->save();
...
+    $field = FieldConfig::create([
+      'field_name' => 'field_test',
+      'entity_type' => 'entity_test',
+      'bundle' => 'entity_test',
+    ]);
+    $field->save();

Nit: no need to create this variable. Just do:

Thing::create([
  …
])->save();

(You only want to assign it to a variable if you're going to use the variable.)

Can be fixed on commit, or not at all :) Doesn't really matter.

Committed 9f85d56 and pushed to 8.0.x. Thanks!

Didn't fix the unused variables... it's a test :)