diff --git a/core/modules/views_ui/src/Controller/ViewsUIController.php b/core/modules/views_ui/src/Controller/ViewsUIController.php index b40bfc8..56fce5f 100644 --- a/core/modules/views_ui/src/Controller/ViewsUIController.php +++ b/core/modules/views_ui/src/Controller/ViewsUIController.php @@ -93,7 +93,12 @@ public function reportFields() { foreach ($views as $view) { $rows[$field_name]['data'][1][] = $this->l($view, new Url('entity.view.edit_form', array('view' => $view))); } - $rows[$field_name]['data'][1] = SafeMarkup::set(implode(', ', $rows[$field_name]['data'][1])); + $item_list = [ + '#theme' => 'item_list', + '#items' => $rows[$field_name]['data'][1], + '#context' => ['list_style' => 'comma-list'], + ]; + $rows[$field_name]['data'][1] = ['data' => $item_list]; } // Sort rows by field name. diff --git a/core/modules/views_ui/src/Tests/ReportFieldsTest.php b/core/modules/views_ui/src/Tests/ReportFieldsTest.php new file mode 100644 index 0000000..2e0c110 --- /dev/null +++ b/core/modules/views_ui/src/Tests/ReportFieldsTest.php @@ -0,0 +1,60 @@ +drupalGet('admin/reports/fields/views-fields'); + $this->assertRaw('Used in views', 'Title appears correctly'); + $this->assertRaw('No fields have been used in views yet.', 'No results message appears correctly.'); + + // Set up the field_test field. + $field_storage = FieldStorageConfig::create([ + 'field_name' => 'field_test', + 'type' => 'integer', + 'entity_type' => 'entity_test', + ]); + $field_storage->save(); + + $field = FieldConfig::create([ + 'field_name' => 'field_test', + 'entity_type' => 'entity_test', + 'bundle' => 'entity_test', + ]); + $field->save(); + + $this->drupalGet('admin/reports/fields/views-fields'); + // Assert that the newly created field appears in the overview. + $this->assertRaw('field_test', 'Field name appears correctly'); + $this->assertRaw('>test_field_field_test', 'View name appears correctly'); + $this->assertRaw('Used in views', 'Title appears correctly'); + } + +}