[D7] Commerce Reorder Line Item

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxartreaktor2501091git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, artreaktor

You should set git default branch as described here: https://www.drupal.org/node/1659588

Hi, artreaktor

There are some issues with your code: http://pareview.sh/pareview/httpgitdrupalorgsandboxartreaktor2501091git
You should fix Drupal code standards.

Also you didn't fix default branch issue.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.


FILE: ...e_reorder_lineitem_handler_field_commerce_reorder_lineitem_button.inc
---------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
16 | ERROR | Method name
| | "commerce_reorder_lineitem_handler_field_commerce_reorder_lineitem_button::option_definition"
| | is not in lowerCamel format
16 | ERROR | Visibility must be declared on method "option_definition"
27 | ERROR | Method name
| | "commerce_reorder_lineitem_handler_field_commerce_reorder_lineitem_button::options_form"
| | is not in lowerCamel format
27 | ERROR | Visibility must be declared on method "options_form"
39 | ERROR | Visibility must be declared on method "construct"
50 | ERROR | Visibility must be declared on method "render"
57 | ERROR | Method name
| | "commerce_reorder_lineitem_handler_field_commerce_reorder_lineitem_button::views_form"
| | is not in lowerCamel format
57 | ERROR | Visibility must be declared on method "views_form"
86 | ERROR | Method name
| | "commerce_reorder_lineitem_handler_field_commerce_reorder_lineitem_button::views_form_submit"
| | is not in lowerCamel format
86 | ERROR | Visibility must be declared on method "views_form_submit"
---------------------------------------------------------------------------

Manual Review:

Automated Review

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them.  However, modules should follow them as closely as possible.

Manual Review

 

Individual user account

 

Yes: Followsthe guidelines for individual user accounts.

 

Master Branch

 

Yes: Follows the guidelines for master branch.

 

Licensing

 

Yes: Follows the licensing requirements.

 

3rd party assets/code

 

Yes: Follows the guidelines for 3rd party assets/code.

 

README.txt/README.md

 

No: Does not follow the guidelines for in-project documentation and/or the README Template.
You are missing an introduction, the configuration heading just tells us what your module does and not how to configure it, you are missing the requirements header(very important since your module does have dependencies.) Please check out the template for README.txt files.

 

Code long/complex enough for review

 

Yes: Follows the guidelines for project length and complexity.

 

Secure code

 

Yes: Meets the security requirements. / No: List of security issues identified.]

 

Coding style & Drupal API usage

 

I would go through the list given by dillix and fix what you can control. If I'm not mistaken, just because the views class doesn't follow naming conventions, it does not mean you are excused as well.
 

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

The readme style alone is surely not an application blocker, anything else that you found or should this be RTBC instead?

As long as the readme style and the list of pareview.sh errors listed by dillix are not blockers, then yes.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account

Yes: Follows / No: Does not follow] the guidelines for individual user accounts.

No duplication

Yes: Does not cause / No: Causes] module duplication and/or fragmentation.

Master Branch

Yes: Follows / No: Does not follow] the guidelines for master branch.

Licensing

Yes: Follows / No: Does not follow] the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. * Lineitem object is not being passed to the commerce_reorder_lineitem_reorder_tab callback, line 64. This is when accessing from admin/commerce/orders/list view page.
2. * Reorder button views field handler doesn't seem to be getting the line item number, returning 0 instead.
3. + Order UI should replace Order as a dependency in the .info file.
4. + Please add info describing permission settings to README.txt
5. Suggest moving constructor to the top of the list of functions, where it would be expected.
6. The automated pareview.sh errors returned on the view class are not applicable in this case

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.