Problem/Motivation

The Views UI tells you that you can enter a path in the form of node/%/feeds, but doing so while adding a menu tab results in a Fatal error.

Twig_Error_Runtime: An exception has been thrown during the rendering of a template ("Some mandatory parameters are missing ("arg_0") to generate a URL for route "view.articles_per_page.page_1".") in "core/themes/classy/templates/navigation/menu-local-task.html.twig" at line 17. in Twig_Template->displayWithErrorHandling() (line 328 of core/vendor/twig/twig/lib/Twig/Template.php).

It works as expected when making the path node/%node/feeds.
The view is accessible in both cases, only the node page that should render the tab blows up.

To reproduce:

  1. Install the standard profile.
  2. Add a content entity reference field to articles and allow pages.
  3. Add a view with a page
    • set the path to node/%/articles
    • set the menu to "menu tab"
    • add a contextual filter with the field added in step 2.
    • add a validation filter: content page bundle
  5. Visit a page content and find a fatal Error

Proposed resolution

fix the bug!

Remaining tasks

User interface changes

no

API changes

probably not..

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because it is a functional regression.
Issue priority Major because it is a functional regression, and results in uncaught exceptions
CommentFileSizeAuthor
#36 2489940-nr-bot.txt6.19 KBneeds-review-queue-bot
#17 menu_path_wildcard-2489940-14.patch6.17 KBsathish.redcrackle
#13 menu_path_wildcard-2489940-13.patch6.03 KBlendude
#13 interdiff-2489940-11-13.txt1.21 KBlendude
#11 2489940-11-TEST_ONLY.patch4.69 KBlendude
#4 2489940-04-TEST-ONLY.patch4.67 KBjhedstrom

Issue fork drupal-2489940

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +VDC
catch’s picture

catch
he/him
Primary language English
commented
Title: Views path with menu tab » Views path with menu tab does not validate and results in fatal error
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Assigned: Unassigned » jhedstrom

This can be reproduced without an entity reference field. Adding a simple 'Content ID' argument is enough to throw the exception.

My guess is that views will need to store the menu path with more detail than '%'. Looking into this now.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Assigned: jhedstrom » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2489940-04-TEST-ONLY.patch4.67 KB

I haven't been able to figure out the exact fix here, but this is a test that illustrates the fatal error.

Status: Needs review » Needs work

The last submitted patch, 4: 2489940-04-TEST-ONLY.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

In PathPluginBase::getRoute(), this logic:

    foreach ($bits as $pos => $bit) {
      if ($bit == '%') {
        // Generate the name of the parameter using the key of the argument
        // handler.
        $arg_id = 'arg_' . $arg_counter++;
        $bits[$pos] = '{' . $arg_id . '}';
        $argument_map[$arg_id] = $arg_id;
      }
      elseif (strpos($bit, '%') === 0) {
        // Use the name defined in the path.
        $parameter_name = substr($bit, 1);
        $arg_id = 'arg_' . $arg_counter++;
        $argument_map[$arg_id] = $parameter_name;
        $bits[$pos] = '{' . $parameter_name . '}';
      }
    }

is what allows %node to properly work (route parameter of arg_0 => node), while % fails because it gets assigned to a route parameter (arg_0 => 0) that the routing system doesn't know how to provide.

The last submitted patch, 4: 2489940-04-TEST-ONLY.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented

The core committers and Views maintainers (alexpott, xjm, effulgentsia, tim.plunkett, and dawehner) agreed that this is a major issue. This is a very common usecase and an exception is being thrown potentially on a lot of user-facing pages when the site builder follows the instructions in the Views UI. The issue is not critical because there is a workaround (using the named argument) and no actual data loss.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Triaged core major

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Needs review
Issue tags: -views
StatusFileSize
new 2489940-11-TEST_ONLY.patch4.69 KB

This is still a problem. Test only patch didn't apply anymore, rerolled.

Status: Needs review » Needs work

The last submitted patch, 11: 2489940-11-TEST_ONLY.patch, failed testing.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2489940-11-13.txt1.21 KB
new menu_path_wildcard-2489940-13.patch6.03 KB

Stab at a fix for this. Not sure if this is the best way to go but it turns the test green so that's something.

Status: Needs review » Needs work

The last submitted patch, 13: menu_path_wildcard-2489940-13.patch, failed testing.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sathish.redcrackle’s picture

sathish.redcrackle commented
StatusFileSize
new menu_path_wildcard-2489940-14.patch6.17 KB

I have modified the patch file. Now the test will get passed.

mikeker’s picture

mikeker commented
Status: Needs work » Needs review

@sathish.redcrackle, thank you for the updated patch! Please include an interdiff so we can easily tell what was changed from one patch to the next. Also, set the status to Needs review when new patches are uploaded so that testbot runs.

Status: Needs review » Needs work

The last submitted patch, 17: menu_path_wildcard-2489940-14.patch, failed testing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

socialnicheguru’s picture

socialnicheguru commented

Path does not apply to 8.5 because the MenuLinkTest.php path has changed to core/modules/views/tests/src/Functional/Plugin/MenuLinkTest.php

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Issue tags: +Needs reroll

As per #22, Needs reroll and to verify this issue still exists.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Issue tags: +Bug Smash Initiative

rpayanm made their first commit to this issue’s fork.

rpayanm opened merge request !2328

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2489940-nr-bot.txt6.19 KB

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

vsujeetkumar made their first commit to this issue’s fork.

vsujeetkumar opened merge request !4952

vsujeetkumar’s picture

vsujeetkumar commented

Tried to rebase the base to 9.5.x (See.. Rebase Document), Something went wrong but not sure, So please have a look and advise. Created a MR, Please ignore if not required.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.