[D7] Media Facebook Video

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxquincyreid2473653git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Beginning review.

Please set your default branch and make a small adjustment in your README file, then I think this is ready to go!

Manual Review

Individual user account

Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation. Like the submitter, I can't find any D7 support for Facebook video using the Media module or other, less well-known modules.

Master Branch

Does not follow the guidelines for master branch.

Licensing

Follows the licensing requirements.

3rd party assets/code

Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Does not (quite) Follow the guidelines for in-project documentation and/or the README Template. You have a link to Devin Carlson's d.o page as the "Maintainer", but he's the maintainer of the Media module, not this new one, is that correct? While I think a link to the Media module would be great alongside its listing in the REQUIREMENTS section, I think listing Devin as a maintainer just creates confusion.

Code long/complex enough for review

Follows the guidelines for project length and complexity.

Secure code

Meets the security requirements.

Coding style & Drupal API usage

1. In the MediaFacebookInternetHandler class, the "parse" function returns a value only if a match is found. Please consider returning something (e.g. "-1") if no match is found, to make it easier to write a test for this function. This is just a suggestion, though.
2. Please consider adding @param and @return values to your doc-blocks.

Neither of these suggestions should be considered a blocker.

This review uses the Project Application Review Template.

• Coder Review:
  

  MediaInternetFacebookHandler.inc
  
  Line 11: @see references should be separated by "," followed by a single space and with no trailing punctuation
  
       * @see hook_media_internet_providers().
  
  media_facebook.theme.inc
  
  Line -1: @file block missing (Drupal Docs)
      
  media-facebook-video.tpl.php
  
  Line -1: @file block missing (Drupal Docs)
  

  These are minors complains no a blocker

• Pareviews.sh - is showing the same minors complains http://pareview.sh/pareview/httpgitdrupalorgsandboxquincyreid2473653git
• media_facebook.formatters.inc - media_facebook_file_formatter_info() should you add the height in there ? Or is not necessary ?
• You should provide the hook_help to allow site builders to find information about your module using Drupal UI.
• README.txt

Something else you should consider is adding this to as new branch of this project https://www.drupal.org/project/media_facebook. This would make user easier to find Media Facebook for D7 and D6.

I did not see any blockers. BTW, I replace "Duplication" word with "Similar" modules, because those are not duplicated module does are similar modules.

This issue is not fixed since the application has not been approved yet. See the workflow: https://www.drupal.org/node/532400

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.