[D7] Geofield Find Address

Check http://pareview.sh/pareview/httpgitdrupalorgsandboxandreyjan2477245git

In addition:
geofield_find_address.js:
1. use context in selector (e.g. $("button.address-gmap-find-address-button”, context))
2. line 29-30 no need to create variable if you use it only once.
geofield_find_address.info:
1. use "scripts[] = js/geofield_find_address.js” for js files, not files.
geofield_find_address.module
1. Use require_once instead of module_load_include, as you know for sure where file is and that it exists, so no need in extra checks (see http://stackoverflow.com/a/7270875)
geofield_find_address.widgets.inc
1. line 55: use single quote (') in strings
drupal_get_path('module', 'geofield_find_address') . '/js/geofield_find_address.js';
as there are no variables inside them.

geofield_find_address.js line 32-33: better to use
else if (...) {}
instead of

else {
  if (...) {}
}

Hi andreyjan

Better if you put the pareview link in description.

Automated Review
No pareview errors found

Manual Review

Individual user account
Yes follow the guideline

No duplication
Try to explain better how your module differ from geofield+address field that also use google maps api and fill coordinates fields showing a map.
see https://www.drupal.org/node/23789

Master Branch
Yes follow the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
- There are no heading and some sections.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements

Looking at your code all seems ok

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

No issues found.

Manual Review

Individual user account

Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation.

Master Branch

Follows the guidelines for master branch.

Licensing

Follows the licensing requirements.

3rd party assets/code

Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Follows the guidelines for project length and complexity.

Secure code

Meets the security requirements.

Coding style & Drupal API usage

Keep it up.

This review uses the Project Application Review Template.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.