[d7] accountcancel_contentassigntootheruser

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual review

1. Individual user account - Yes: Application issue contains a link to the project page and a working "git clone" command.
2. No duplication - Yes: Does not cause module duplication.
3. Master Branch - Yes: Master branch is set proper to 7.x-1.x
4. Licensing - Yes: Repository does not contain a ‘LICENSE.txt’ file.
5. 3rd party code/content - No: Repository does not contain any 3rd party code.
6. Project page docs- Please increase description: Project page contains not enough information. Please follow this guidelines.
7. Repository contains a detailed README.txt- Maybe you can construct more detailed README.txt ?: Please follow this guidelines.
8. Code contains a well-balanced amount of inline-comments - Yes Code contains inline comments and function comments.
9. Code and Drupal API : In file usercancel_contentassigntootheruser,js, probably, the better way is to use Drupal behavior instead $(document).ready(). Please read this article, Behaviors section.

Please specify your project difference with this project(https://www.drupal.org/project/usercancel_contentassigntoadmin). I have checked and found that the project only provides to select the user during the cancellation if it is only single extra difference then I would suggest to please collaborate with the module author of usercancel_contentassigntoadmin,As Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the usercancel_contentassigntoadmin module and discuss with this feature. if the maintainers will not agree then re open this issue.
If have other differences other than I specified above then add a comment.
Manual Review (Commit 365587b):

1. (*)usercancel_contentassigntootheruser_form_user_multiple_cancel_confirm_alter : It is not always sure that role id 3 will exist always.We can delete the role id 3 after the drupal vanilla installation.So I would suggest to keep it either 2(authenticated) as default because we cant't remove that role.
2. (*)usercancel_contentassigntootheruser_form_user_multiple_cancel_confirm_alter : This function is returning the list of all users with particular role usercancel_contentassigntootheruser_get_users.If a drupal site has more than million of users with that particular role then that page will hang.So I would suggest to change the users_list select list to autocomplete field.
3. usercancel_contentassigntootheruser_user_cancel : $userid = $edit['users_list']; If the user will select None value from the select list returned by function usercancel_contentassigntootheruser_get_users, then it will make break the update in this function usercancel_contentassigntootheruser_user_cancel because uid is a numeric field.I would suggest to remove the none option from the userlist array returned by usercancel_contentassigntootheruser_get_users function.
4. usercancel_contentassigntootheruser.js : Use Drupal.behaviors, not jQuery(document).ready() in your js file. https://www.drupal.org/node/304258

Since we don't block applications on duplication anymore, this should go back to "needs review". If there is only this minor differences to the existing module, then we cannot give the git vetted user role away and will do a manual promotion of this single project.

@shipra.wasson: please reconsider contributing to the existing project or set this back to "needs review" if you must publish this as separate module.

Thanks @klausi,
So how are we going to deal with the old postponed applications ?

I think we can leave them as they are, the applicants can set them back to "needs review" if they want to.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Duplication is no longer a blocker now, so this application can be proceeded.please take additional bonus that would help speed up the process

Nice module. Looks like RTBC +1

Thanks
Viswanath Polaki

Removing review bonus tag, you have not done all manual reviews, you just pointed out a missing git clone link. Make sure to read through the source code of the other projects, as requested on the review bonus page.

Hello!
I think you need to rewrite your hook_menu like this:

function usercancel_contentassigntootheruser_menu() {
  // Path with autocomplete function for users.
  $items['user-list/autocomplete/%/%'] = array(
    'title' => 'Autocomplete for users',
    'page callback' => 'usercancel_contentassigntootheruser_list_autocomplete',
    'page arguments' => array(2, 3),
    'access arguments' => array('access content'),
    'type' => MENU_CALLBACK,
  );
  return $items;
}

Here you will pass 2 arguments:

• 2 - role ID
• 3 - user_mail

And so, you don't need to use args(2) - I think it's a bad style.
You need to correct your page callback to:

function usercancel_contentassigntootheruser_list_autocomplete($role, $string) {
  #your code.
}

For me it looks better and it more drupal way than earlier.
Thank you.
Best regards.

Automated Review :

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes : Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. usercancel_contentassigntootheruser.js : Drupal.behaviors.userCancel we should use the module_name namespace with in the Drupal.behaviours object.you can also use the $ instead of jQuery when accessing the values.
2. Suggestion : Move hook_help to top of all the functions in .module file.
3. usercancel_contentassigntootheruser_form_user_multiple_cancel_confirm_alter : Why default value 2(authenticated role), similarly in usercancel_contentassigntootheruser_get_users
4. usercancel_contentassigntootheruser_list_autocomplete : Why this function needed can't use the user_autocomplete function

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Removing the PAReview: Single project promote tag and not changing status due to open questions.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Looks like RTBC +1

manual review:

1. project page is a bit short, please follow https://www.drupal.org/node/997024
2. https://www.drupal.org/project/move_user and https://www.drupal.org/project/usercancel_contentassigntoadmin . This sounds like a feature that should live in the existing move_user project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Instead of publishing another duplicate project please open an issue in the move_user issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
3. usercancel_contentassigntootheruser.js: not sure I understand this correctly but it looks like you want to hide certain input fields. That should be done with the Drupal #states API, no need to write custom JS for that. See https://api.drupal.org/api/drupal/includes!common.inc/function/drupal_pr...
4. usercancel_contentassigntootheruser_menu(): doc block is wrong, this is not hook_help().
5. usercancel_contentassigntootheruser_menu(): I think the permission is wrong, should be "access user profiles" instead.
6. usercancel_contentassigntootheruser_list_autocomplete(): use @param to document parameters, see https://www.drupal.org/coding-standards/docs#param

But otherwise looks good to me.

Thanks for your contribution, Shipra!

I updated your account so you can create new projects as either a sandbox or a "full" project. As I already said please do not promote this particular sandbox, because it would duplicate 2 already existing projects. Please contribute to those instead!

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Found an errors in usercancel_contentassigntootheruser.module

FOUND 4 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
166 | ERROR | [x] There must be exactly one blank line before the tags in
| | a doc comment
166 | ERROR | [x] Expected "string or int or object..." but found "type"
| | for parameter type
167 | ERROR | [ ] Parameter comment must start with a capital letter
167 | ERROR | [ ] Parameter comment must end with a full stop