Trrybe is a drupal distribution which is focussed mainly on giving users a platform where they can find all the relevant/uploaded videos at one place.

--------------------------------------------------------------------------------------

Project link: https://www.drupal.org/sandbox/nitvirus/2448621

Git : git clone --branch 7.x-1.x http://git.drupal.org/sandbox/nitvirus/2448621.git trrybe

cd trrybe

-------------------------------------------------------------------------------------

The intended Drupal core version is drupal 7.x.

You can find more description about Trrybe on the project page.

Review Bonus:

links to review: https://www.drupal.org/node/2442479#comment-9814765
https://www.drupal.org/node/2369009#comment-9818783
https://www.drupal.org/node/2541442#comment-10334833
https://www.drupal.org/node/2567181#comment-10334841

CommentFileSizeAuthor
#9 updates.png143.34 KBmanjit.singh
#9 error.png28.04 KBmanjit.singh

Comments

nitvirus’s picture

Issue summary: View changes
manjit.singh’s picture

Status: Needs review » Needs work

Found some coding standard issues http://pareview.sh/pareview/httpgitdrupalorgsandboxnitvirus2448621git
Please take a look into it.

RavindraSingh’s picture

@Manjit, These are contributed modules/profiles doesn't require any manual changes.

@nitvirus, please remove unnecessary files .DS_STORE kinds of hidden files.
Please make description more clear for reviewers. for e.g https://www.drupal.org/node/2466833 and set the expectation from the reviewers you are looking for.
Add demo URL itself in the description with open user credentials. So reviewer can check/test/compare it quickly.

Will do more review after these modification gets done.

Thanks,
Ravin

rishikant05’s picture

@RavindraSingh, I have removed all the hidden and unnecessary files as you mentioned above.

@Manjit, Most of the thing in the pareview are referring to contributed module and modules which are made through features. And rest of the things are corrected by us.

Thanks,
Rishi

nitvirus’s picture

Thanks for the reviews guys.

@RavindraSingh: @rishikant005 has update the codebase.
@Manjit.Singh: Saw the report, the majority of things are coming through features and libraries. We will try to correct the remaining things.

Thanks again.

manjit.singh’s picture

Thanks @rishikant005 @nitvirus Code looks fine in pareview... :)

Remove LICENSE.txt, it will be added by drupal.org packaging automatically. ( in root directory only )

I think it should be added by community members.
But Because of it is full drupal distribution so dont sure about this file, Lets wait for other's review :)

manjit.singh’s picture

Status: Needs work » Needs review
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

manjit.singh’s picture

Status: Needs review » Needs work
StatusFileSize
new28.04 KB
new143.34 KB

hey, I am creating "content page" as a admin. Content successfully created but it is showing some error

Recoverable fatal error: Argument 3 passed to menu_tree_prune_tree() must be of the type array, boolean given, called in C:\xampp\htdocs\trrybe\profiles\trrybe\modules\contrib\menu_block\menu_block.module on line 375 and defined in menu_tree_prune_tree() (line 671 of C:\xampp\htdocs\trrybe\profiles\trrybe\modules\contrib\menu_block\menu_block.module).

Or am i missing something to install ? Please check screenshot (error.png) as well.

Also some updates need to do in this distribution, Please check highlighted area of updates.png . I have not updated these modules locally after reading this notification.

nitvirus’s picture

Issue summary: View changes
manjit.singh’s picture

Issue summary: View changes
Issue tags: +PAreview: review bonus
nitvirus’s picture

Issue summary: View changes
manjit.singh’s picture

Status: Needs work » Needs review
klausi’s picture

Issue tags: -PAreview: review bonus

Removing review bonus tag, only 2 manual review are listed in the issue summary? Make sure to complete 3 manual reviews before adding the tag.

nitvirus’s picture

Issue summary: View changes
nitvirus’s picture

Issue tags: +PAreview: review bonus

Adding review bonus tag.

klausi’s picture

Status: Needs review » Needs work

A Drupal distribution should not contain the full source code of Drupal core. You should have drush make files that are used for packaging on drupal.org for core and contributed modules. The git repository should only contain the custom code of your distribution. See https://www.drupal.org/documentation/build/distributions and https://www.drupal.org/node/1476014

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

avpaderno’s picture

Component: other » distribution/profile