Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Apr 2015 at 18:28 UTC
Updated:
30 Jul 2015 at 18:34 UTC
Jump to comment: Most recent
Comments
Comment #1
artis commentedI ran the project through pareview.sh and below is the report. I will followup with a manual review early next week.
-Art
_____________________
Git errors:
Git default branch is not set, see the documentation on setting a default branch.
Review of the 7.x-1.x branch (commit 19687c0):
README.txt or README.md is missing, see the guidelines for in-project documentation.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: /var/www/drupal-7-pareview/pareview_temp/update_extended.module
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
6 | ERROR | There must be exactly one blank line after the file comment
-------------------------------------------------------------------------
FILE: /var/www/drupal-7-pareview/pareview_temp/update_extended.info
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
4 | ERROR | [ ] Drupal 7 core already requires PHP 5.2
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 91ms; Memory: 6.75Mb
DrupalPractice has found some issues with your code, but could be false positives.
FILE: /var/www/drupal-7-pareview/pareview_temp/update_extended.module
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
---------------------------------------------------------------------------
24 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
25 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
26 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
28 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
31 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
152 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
153 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
158 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
---------------------------------------------------------------------------
Time: 45ms; Memory: 5Mb
Codespell has found some spelling errors in your code.
./update_extended.module:71: releses ==> releases
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
Comment #2
jcontreras commentedI fixed the issues pointed out on the last review and committed the updates to the project.
I was not able to fix the "WARNING: $form_state['input'], use $form_state['values'] instead where possible", because the "value" key is not available in the stack where I'm using it.
Comment #3
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjcontreras782463219git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
jcontreras commentedI fixed the major errors and added the Default git. But I was not able to fix the "WARNING: $form_state['input'], use $form_state['values'] instead where possible", because the "value" key is not available in the stack where I'm using it.
Comment #5
andrdrx commentedHello, Jcontreras!
I see inline CSS in your .module file on line 53. Maybe it is good idea to separate CSS from PHP code to .css file ? How do you think?
Comment #6
jcontreras commentedThanx andrdrx - I was waiting to do another release that may have more css to move the css to it's own but I think it would be best to move it on its own now better than later as per your suggestion. Thanx! I have updated the code. =)
Comment #7
jain_deepak commentedHi,
some manually code review:
update_extended.module
Comment #8
jcontreras commentedHi @jain_deepak , I have updated the code as per your review. Thank you!
Comment #9
jcontreras commentedComment #10
artis commentedI installed on a site that was already up to date on all modules. When navigating to the update page I received this error:
Warning: Invalid argument supplied for foreach() in update_extended_form_alter() (line 38 of /home/txc/new_public_html/sites/all/modules/update_extended/update_extended.module).It looks like $form['projects']['#options'] is empty when there are no updates needed.
Wrapping the foreach on lines 38-43 in a conditional should resolve.
Everything else I tested operates as expected.
Comment #11
jcontreras commentedThanx Artis! I fixed the error please check again and let me know if anything else. =)
Comment #12
artis commentedEverything checks out here. Module does what it intends and all issues appear to be resolved.
Comment #13
klausiRemoving review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.
Comment #14
cweagansThanks for your contribution!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.