Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Jan 2015 at 21:53 UTC
Updated:
13 Jul 2015 at 15:04 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
yuriy.kostin commentedHi Matej,
My suggestions follow:
Comment #3
yuriy.kostin commentedComment #4
matej.lehotsky commentedHi,
thanks for review! I changed module to use Drupal Behaviors in js.
Comment #5
matej.lehotsky commentedComment #6
darol100 commented@raweez
There is still a lot complains on the Pareview.sh.*
Manual Review
No hook_help, you should consider adding the hook_help even if display the same information as the README.txt. *
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #7
klausiThose issues by pareview.sh should definitely be fixed, but are not major application blockers. Anything else that you found or should this be RTBC instead?
Comment #8
darol100 commentedNot seeing any blocking issues to this module.
Comment #9
avpadernoThanks for your contribution!
I updated your account so you can promote new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thank you to the dedicated reviewer(s) as well.